Skip to content

usrsctp: 0.9.5.0 -> unstable-2023-05-24#238812

Closed
erdnaxe wants to merge 1 commit intoNixOS:stagingfrom
erdnaxe:usrsctp-update-staging
Closed

usrsctp: 0.9.5.0 -> unstable-2023-05-24#238812
erdnaxe wants to merge 1 commit intoNixOS:stagingfrom
erdnaxe:usrsctp-update-staging

Conversation

@erdnaxe
Copy link
Member

@erdnaxe erdnaxe commented Jun 20, 2023

Description of changes

usrsctp in NixPkgs is too old for OBS Studio WHIP support.

This pull request proposes to update usrsctp to the latest version to fix #237099.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@erdnaxe erdnaxe marked this pull request as ready for review June 20, 2023 19:47
@ofborg ofborg bot requested a review from misuzu June 20, 2023 20:39
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jun 20, 2023
@misuzu
Copy link
Contributor

misuzu commented Jun 21, 2023

I think it's better to just use the vendored version of usrsctp in libdatachannel.
Also https://dont-ship.it/

@erdnaxe erdnaxe closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants