Skip to content

plog: init at 1.1.9#238806

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
erdnaxe:plog
Jun 24, 2023
Merged

plog: init at 1.1.9#238806
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
erdnaxe:plog

Conversation

@erdnaxe
Copy link
Member

@erdnaxe erdnaxe commented Jun 20, 2023 •
edited
Loading

Description of changes

Motivation: required for #237099 which will be required for next OBS Studio release.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@erdnaxe erdnaxe mentioned this pull request Jun 20, 2023
Merged
12 tasks
@erdnaxe erdnaxe marked this pull request as ready for review June 20, 2023 19:28
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 20, 2023
@ofborg ofborg bot requested a review from raphaelr June 20, 2023 20:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2023
raphaelr
raphaelr approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

nixos-discourse commented Jun 24, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/998

@erdnaxe
Copy link
Member Author

erdnaxe commented Jun 24, 2023

Result of nixpkgs-review pr 238806 run on aarch64-linux 1

2 packages built:
  • plog
  • plog.dev

@SuperSandro2000 SuperSandro2000 merged commit 483e30a into NixOS:master Jun 24, 2023
@de11n de11n mentioned this pull request Jul 11, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@raphaelr raphaelr raphaelr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erdnaxe @nixos-discourse @raphaelr @SuperSandro2000