python3Packages.csv2md: init at 1.1.1#236913
python3Packages.csv2md: init at 1.1.1#236913MatthewCroughan wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
|
Result of 4 packages built:
|
|
|
||
| buildPythonPackage rec { | ||
| pname = "csv2md"; | ||
| version = "1.1.1"; |
There was a problem hiding this comment.
It seems that 1.2.0 was released 3 months ago.
https://github.com/lzakharov/csv2md/releases/tag/v1.2.0
|
|
||
| buildPythonPackage rec { | ||
| pname = "csv2md"; | ||
| version = "1.1.1"; |
There was a problem hiding this comment.
| version = "1.1.1"; | |
| version = "1.1.1"; | |
| pyproject = true; |
Could you please set pyproject = true?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters
|
|
||
| src = fetchFromGitHub { | ||
| owner = "lzakharov"; | ||
| repo = pname; |
There was a problem hiding this comment.
| repo = pname; | |
| repo = "csv2md"; |
pname and repo are semantically different, so please avoid reusing pname.
| owner = "lzakharov"; | ||
| repo = pname; | ||
| rev = "v${version}"; | ||
| sha256 = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4="; |
There was a problem hiding this comment.
| sha256 = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4="; | |
| hash = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4="; |
| rev = "v${version}"; | ||
| sha256 = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4="; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Could you please enable tests with pythonImportsCheck and pytestCheckHook?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#testing-python-packages-testing-python-packages
|
|
||
| meta = { | ||
| homepage = "https://github.com/lzakharov/csv2md"; | ||
| description = "Command line tool for converting CSV files into Markdown tables."; |
There was a problem hiding this comment.
| description = "Command line tool for converting CSV files into Markdown tables."; | |
| description = "Command line tool for converting CSV files into Markdown tables"; |
Please don't include a trailing period.
https://nixos.org/manual/nixpkgs/stable/#var-meta-description
| description = "Command line tool for converting CSV files into Markdown tables."; | ||
| license = lib.licenses.mit; | ||
| maintainers = [ lib.maintainers.matthewcroughan ]; | ||
| platforms = lib.platforms.all; |
There was a problem hiding this comment.
| platforms = lib.platforms.all; |
We don't need to set platforms for python package since it is already set by default.
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
ghost
closed this
4 participants
Description of changes
Adds csv2md to nixpkgs
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)