Skip to content

csv2md: init at 1.3.0#298707

Merged
pbsds merged 1 commit intoNixOS:masterfrom
t4ccer:t4/csv2md/init
Jun 5, 2024
Merged

csv2md: init at 1.3.0#298707
pbsds merged 1 commit intoNixOS:masterfrom
t4ccer:t4/csv2md/init

Conversation

@t4ccer
Copy link
Member

@t4ccer t4ccer commented Mar 24, 2024

Description of changes

Added csv2md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 24, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both a library and CLI tool

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2024
Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine on x86_64-linux and aarch64-darwin ✔️

If you want to make csv2md available as csv2md python application, you can add this in the pkgs/top-level/all-packages.nix as well :)

csv2md = with python3.pkgs; toPythonApplication csv2md;

@t4ccer
Copy link
Member Author

t4ccer commented Mar 26, 2024

Yeah, that's a good idea.

BTW, is there any docs whether we should prefer python3Packages or python3.pkgs?

@t4ccer
Copy link
Member Author

t4ccer commented Mar 26, 2024

I'll use #295031 (comment) as my point of reference

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 26, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1563

@pbsds pbsds merged commit 140fef3 into NixOS:master Jun 5, 2024
@t4ccer t4ccer deleted the t4/csv2md/init branch November 10, 2024 05:28
@ghost ghost mentioned this pull request Jan 22, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants