Skip to content

python3Packages.csv2md: init at 1.1.1 #236913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatthewCroughan wants to merge 1 commit into from
Closed

python3Packages.csv2md: init at 1.1.1 #236913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions pkgs/development/python-modules/csv2md/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{ lib
, buildPythonPackage
, fetchFromGitHub
}:

buildPythonPackage rec {
pname = "csv2md";
version = "1.1.1";
Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that 1.2.0 was released 3 months ago.
https://github.com/lzakharov/csv2md/releases/tag/v1.2.0

Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.1.1";
version = "1.1.1";
pyproject = true;

Could you please set pyproject = true?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters


src = fetchFromGitHub {
owner = "lzakharov";
repo = pname;
Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = pname;
repo = "csv2md";

pname and repo are semantically different, so please avoid reusing pname.

rev = "v${version}";
sha256 = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4=";
Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4=";
hash = "sha256-fyXM88hawO6Q9pwMgVtjXaPVEaP36TOmoYL0c7RFDZ4=";

};

Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please enable tests with pythonImportsCheck and pytestCheckHook?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#testing-python-packages-testing-python-packages

meta = {
homepage = "https://github.com/lzakharov/csv2md";
description = "Command line tool for converting CSV files into Markdown tables.";
Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Command line tool for converting CSV files into Markdown tables.";
description = "Command line tool for converting CSV files into Markdown tables";

Please don't include a trailing period.
https://nixos.org/manual/nixpkgs/stable/#var-meta-description

license = lib.licenses.mit;
maintainers = [ lib.maintainers.matthewcroughan ];
platforms = lib.platforms.all;
Copy link
Member

@natsukium natsukium Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = lib.platforms.all;

We don't need to set platforms for python package since it is already set by default.

};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2214,6 +2214,8 @@ self: super: with self; {

csvw = callPackage ../development/python-modules/csvw { };

csv2md = callPackage ../development/python-modules/csv2md { };

ctap-keyring-device = callPackage ../development/python-modules/ctap-keyring-device { };

cu2qu = callPackage ../development/python-modules/cu2qu { };
Expand Down