elmPackages: nodejs_14 -> nodejs_18.#233296
Merged
RaitoBezarius merged 1 commit intoNixOS:masterfrom May 21, 2023
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
Result of 1 package failed to build:
14 packages built:
|
Follow-up to NixOS#230543, we were still using nodejs_14 for some packages. I also turned the node dependency into an input, so that it can be overriden, which is handy for local testing.
r-vdp
force-pushed
the
elmPackages_nodejs_18
branch
from
c299b0b to
714c4d3
Compare
Contributor
Author
|
@RaitoBezarius: fixed. It seems that something is missing in the binwrap patching hook though, this is the second package to need this additional manual patch. We'd need to investigate that at some point. |
Member
|
Result of 17 packages built:
|
RaitoBezarius
approved these changes
May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Follow-up to #230543, we were still using nodejs_14 for some packages (e.g.
elmPackages.elm-language-server).I also turned the node dependency into an input, so that it can be overriden, which is handy for local testing.
Ping @turboMaCk
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)