Skip to content

elmPackages: nodejs_14 -> nodejs_18. #233296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaitoBezarius merged 1 commit into from
May 21, 2023
Merged

elmPackages: nodejs_14 -> nodejs_18. #233296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions pkgs/development/compilers/elm/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{ pkgs, lib, makeWrapper }:
{ pkgs
, lib
, makeWrapper
, nodejs ? pkgs.nodejs_18
}:

let

# To control nodejs version we pass down
nodejs = pkgs.nodejs_18;

fetchElmDeps = pkgs.callPackage ./fetchElmDeps.nix { };

# Haskell packages that require ghc 8.10
Expand Down Expand Up @@ -115,8 +115,7 @@ let
};

nodePkgs = pkgs.callPackage ./packages/node-composition.nix {
inherit pkgs;
nodejs = pkgs.nodejs_14;
inherit pkgs nodejs;
inherit (pkgs.stdenv.hostPlatform) system;
};

Expand Down Expand Up @@ -152,14 +151,23 @@ in lib.makeScope pkgs.newScope (self: with self; {
};
};
} // (hs810Pkgs self).elmPkgs // (hs92Pkgs self).elmPkgs // (with elmLib; with (hs810Pkgs self).elmPkgs; {
elm-verify-examples = patchBinwrap [elmi-to-json] nodePkgs.elm-verify-examples // {
elm-verify-examples = let
patched = patchBinwrap [elmi-to-json] nodePkgs.elm-verify-examples // {
meta = with lib; nodePkgs.elm-verify-examples.meta // {
description = "Verify examples in your docs";
homepage = "https://github.com/stoeffel/elm-verify-examples";
license = licenses.bsd3;
maintainers = [ maintainers.turbomack ];
};
};
in patched.override (old: {
preRebuild = (old.preRebuild or "") + ''
# This should not be needed (thanks to binwrap* being nooped) but for some reason it still needs to be done
# in case of just this package
# TODO: investigate, same as for elm-coverage below
sed 's/\"install\".*/\"install\":\"echo no-op\",/g' --in-place node_modules/elmi-to-json/package.json
'';
});

elm-coverage = let
patched = patchNpmElm (patchBinwrap [elmi-to-json] nodePkgs.elm-coverage);
Expand Down