nixos/epgstation: add a new option 'ffmpeg'#187120
nixos/epgstation: add a new option 'ffmpeg'#187120midchildan wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
| }; | ||
|
|
||
| ffmpeg = lib.mkOption { | ||
| default = pkgs.ffmpeg-full; |
There was a problem hiding this comment.
Does it require ffmpeg-full or could it do with e.g. ffmpeg-headless?
The closure size difference is striking. 1.05 GB vs 169 MB.
There was a problem hiding this comment.
Practically, it's required for performance reasons. EPGStation streams videos, so it needs hardware accelerated encoding to get acceptable performance. ffmpeg-headless drops support for those, which is a deal breaker for this use case.
There was a problem hiding this comment.
Hardware acceleration usually comes via VAAPI or VDPAU/NVENC/NVDEC, all of which are support by ffmpeg-headless, so I'm not sure what you are missing.
There was a problem hiding this comment.
Sorry, I missed that. Last time I checked, ffmpeg-headless didn't support libmfx and I misremembered that as not having support for hardware acceleration in general.
I'll fix it in #233053.
There was a problem hiding this comment.
This should use mkPackageOption
|
I turned this PR to draft because it's now included in #233053. |
|
Since the PRs already exist, I think all PRs would be merged faster if you wouldn't have combined them, keeping the scope of each one a bit smaller. |
3 participants
Description of changes
This option sets the preferred ffmpeg package for use by the epgstation module.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes