Skip to content

ntfy-sh: 2.4.0 -> 2.5.0#232995

Merged
fpletz merged 1 commit intoNixOS:masterfrom
arjan-s:bump-ntfysh
May 22, 2023
Merged

ntfy-sh: 2.4.0 -> 2.5.0#232995
fpletz merged 1 commit intoNixOS:masterfrom
arjan-s:bump-ntfysh

Conversation

@arjan-s
Copy link
Contributor

@arjan-s arjan-s commented May 20, 2023

Release notes: https://docs.ntfy.sh/releases/#ntfy-server-v250
Diff: binwiederhier/ntfy@v2.4.0...v2.5.0

This update causes the pkg-config: command not found error again on my nixpkgs-review command, but since others didn't have that with 2.4.0, I'm posting the update anyway. So please test the build before merging!

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@JulienMalka
Copy link
Member

Result of nixpkgs-review pr 232995 run on x86_64-linux 1

1 package failed to build:
  • ntfy-sh

Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some kind of error with gyp:

npm ERR! /nix/store/rhvbjmcfnkg8i2dxpzr114cp1ws7f667-bash-5.2-p15/bin/sh: line 1: pkg-config: command not found
npm ERR! gyp: Call to 'pkg-config pixman-1 --libs' returned exit status 127 while in binding.gyp. while trying to load binding.gyp
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/nix/store/6aphgr19pzc8v416zaf6vbs7r9jsbajp-nodejs-18.16.0/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:325:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:291:12)
npm ERR! gyp ERR! System Linux 5.15.110
npm ERR! gyp ERR! command "/nix/store/6aphgr19pzc8v416zaf6vbs7r9jsbajp-nodejs-18.16.0/bin/node" "/nix/store/6aphgr19pzc8v416zaf6vbs7r9jsbajp-nodejs-18.16.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--update-bi>
npm ERR! gyp ERR! cwd /nix/store/h59y6ayz8mx1isf6v5gx2fsg2r0i99gr-node-dependencies-ntfy-1.0.0/ntfy/node_modules/canvas
npm ERR! gyp ERR! node -v v18.16.0
npm ERR! gyp ERR! node-gyp -v v9.3.1
npm ERR! gyp ERR! not ok

@ofborg ofborg bot requested a review from fpletz May 20, 2023 11:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 20, 2023
@arjan-s
Copy link
Contributor Author

arjan-s commented May 20, 2023

Thanks for testing! In that case I'll resurrect the fix from #230188 later today

@arjan-s
Copy link
Contributor Author

arjan-s commented May 20, 2023

This should do it

@arjan-s
Copy link
Contributor Author

arjan-s commented May 20, 2023

Result of nixpkgs-review pr 232995 run on x86_64-linux 1

1 package built:
  • ntfy-sh

@fpletz fpletz merged commit 0ee5bb2 into NixOS:master May 22, 2023
@arjan-s arjan-s deleted the bump-ntfysh branch May 28, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants