Skip to content

Comments

Unbreak snappy and tensorflow Haskell packages#217811

Closed
mikesperber wants to merge 21 commits intoNixOS:masterfrom
mikesperber:unbreak-snappy-haskell-tensorflow
Closed

Unbreak snappy and tensorflow Haskell packages#217811
mikesperber wants to merge 21 commits intoNixOS:masterfrom
mikesperber:unbreak-snappy-haskell-tensorflow

Conversation

@mikesperber
Copy link
Contributor

Description of changes

This unbreaks the Haskell TensorFlow bindings, and - as it's a dependency - the snappy package.

This obsoletes #119411.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

sternenseemann and others added 21 commits February 19, 2023 10:28
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
Both packages had a new release fixing the issues we found after the
last bump, so they are easily fixed.
Unbreak tdlib and its dependencies by same upstream (tdlib-types,
tdlib-gen, language-tl).

Co-authored-by: sternenseemann <sternenseemann@systemli.org>
Cabal 3.8 and friends support process 1.6.17.0 which has recently been
released on Hackage, so we can fix the evaluation errors this way.
aarch64-linux will continue failing unless we find another solution.
For x86_64-darwin we won't learn anything by it being a constaint star
in our build failure reports.
`ghc-pkg list` tells us everything hackage2nix needs to know. In the
past the core-packages list and compiler setting in hackage2nix was
maintained manually which inevitably leads to it being forgot once in a
while – this will then mess with flag resolution when generating the
package set in some cases. Luckily, we can just let a simple derivation
do this for us.

Resolves NixOS#202621.
Espial was broken because the version being tracked had a restrictive upper
bound on bytestring that isn't neccessary. Here we jailbreak after asserting
the version is 0.0.11 so that it fails once we there's a new release.
haskellPackages.espial: Use latest on GitHub (0.0.16) to unbreak
 haskell.packages.ghc94.ormolu: fix eval by bumping version
This just applies in the patches from a long-standing unmerged pull
request.

This transitively also unbreaks snappy-framing and snappy-lazy.
This just moves the package to the current head in the official repo,
which has since seen patches that unbreak the ghc-9 build and work
with our version of TensorFlow.
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 23, 2023
@mikesperber
Copy link
Contributor Author

Sorry, wrong base branch, will try again momentarily.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Feb 23, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants