haskellPackages.espial: Use latest on GitHub (0.0.16) to unbreak #217010
haskellPackages.espial: Use latest on GitHub (0.0.16) to unbreak #217010cdepillabout merged 3 commits intoNixOS:haskell-updatesfrom
Conversation
dalpd
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
We generally prefer applying patches, rather than overriding the source, since patches will (likely) break when a new version is released to Hackage. When we override the source, we may forget about the override and end up many versions behind.
Would it be possible to get to the latest version with a patch file? Also, could you create an issue on the repo asking for a Hackage release?
There was a problem hiding this comment.
Ah yeah, I was trying to apply an additional patch first to get things working and seeing this was behind thought I'd just replace the source, but what you said makes sense. I'll open an issue and update this to use another patch!
There was a problem hiding this comment.
@cdepillabout Actually, do you think it makes sense to just jailbreak this for now since the upper bound on bytestring is the only thing causing the build to fail? We can keep an eye on the issue and go with a local patch file if we don't hear back.
I could also just use this patch but then would have to have almost a dozen of files listed under excluded for it to work.
There was a problem hiding this comment.
In general: When a patch is not feasible a jailbreak + an assert on the current version is probably the right way to go.
There was a problem hiding this comment.
Alright, that's good know! Updated to assert the current version and jailbreak.
Espial was broken because the version being tracked had a restrictive upper bound on bytestring that isn't neccessary. Here we jailbreak after asserting the version is 0.0.11 so that it fails once we there's a new release.
dalpd
force-pushed
the
dad-fix-espial
branch
from
6b531b3 to
dbe6781
Compare
|
Looks good, thanks! |
3 participants
Description of changes
Espial was broken because the version being tracked had a restrictive upper
bound on bytestring, but upstream doesn't have that constraint anymore.
Things done
Replacing the espial source with the latest available upstream. Also putting myself down as the maintainer for this package and patat.
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)