haskell.packages.ghc94.ormolu: fix eval by bumping version

[raehik]

Description of changes

The ormolu pin in configuration-ghc-9.4.x.nix looks for version 0.5.2.0, but the one currently available in nixpkgs is 0.5.3.0 (released on Hackage late Jan). Commands like nix build haskell.packages.ghc94.ormolu fail with the following error:

error: attribute 'ormolu_0_5_2_0' missing

       at /nix/store/...-source/pkgs/development/haskell-modules/configuration-ghc-9.4.x.nix:198:25:

          197|   # https://github.com/tweag/ormolu/issues/941
          198|   ormolu = doDistribute self.ormolu_0_5_2_0;
             |                         ^
          199|   fourmolu = overrideCabal (drv: {
       Did you mean one of ormolu_0_5_3_0 or ormolu_0_2_0_0?

Following the former suggestion fixes the issue.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[raehik]

A temporary fix in the meantime would be nice too, but I don't know how to override configuration-ghc-9.4.x.nix, if it's even possible.

[maralorn]

Thank you for this PR! Content looks fine.

Can you please reword the commit to something like haskell.packages.ghc94.ormolu: Fix eval by bumping version. (The part in front of the colon is the important one to fit our contributing guidelines.)

The PR framing might be a bit misleading. ormolu is not a dependency of ghc, so it does not break its build.
Most likely you are using a dev-environment which depends on ormolu.

[maralorn]

Oh, and you can totally fix this in the interim with an overlay. It should work with something like

haskell.packages.ghc94.override { overrides = [ (final: prev: { ormolu = final.ormolu_0_5_3_0; })  ]; }

[raehik]

It works with haskell.packages.ghc94.override { overrides = final: prev: { ormolu = final.ormolu_0_5_3_0; }; };! Thanks. I'll tidy up this PR as you said. (My limited knowledge on the Haskell setup in Nix & my use of haskell-flake had me thinking haskell.packages.ghc94 was the compiler, apologies.)

[maralorn]

Thanks!