-
-
Notifications
You must be signed in to change notification settings - Fork 18k
cc-wrapper, binutils-wrapper: add tests for hardening-flags-handling #217390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2023
7b35404 to
b618a47
Compare
12 tasks
Contributor
Author
|
@ofborg eval |
Contributor
Author
|
Interesting things about this if reviewed now:
|
Member
I just ran into similar issue in #223671 (comment) and wonder if |
b618a47 to
9e81849
Compare
12 tasks
9e81849 to
0ad3ea5
Compare
0ad3ea5 to
fde4ba4
Compare
12 tasks
fde4ba4 to
faa4350
Compare
7c6f434c
approved these changes
Jul 30, 2023
Contributor
Author
|
(not actually going to merge this until we have a better idea about what the desired behaviour is...) |
12 tasks
most tests use debian-devscripts' hardening-check, so only work on ELF systems and can only detect a limited subset of flags. some extra tests actually execute fortify-protected programs and should be slightly more universally applicable.
faa4350 to
e0f6367
Compare
Contributor
Author
|
(rebased, adjusted expected results for current nixpkgs) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: testing
Tooling for automated testing of packages and modules
8.has: package (new)
This PR adds a new package
8.has: tests
This PR has tests
10.rebuild-darwin: 1-10
This PR causes between 1 and 10 packages to rebuild on Darwin.
10.rebuild-darwin: 1
This PR causes 1 package to rebuild on Darwin.
10.rebuild-linux: 101-500
This PR causes between 101 and 500 packages to rebuild on Linux.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This uses
debian-devscripts'hardening-checkfor most checks, which only works on ELF systems and can only detect a limited subset of flags.Tests mentioning "fortify3" depend on the fortify3 support currently in staging (#212498, #217394), but I've directed this at master to make it easier for people to test. Expect eval errors for those tests until this staging cycle makes it to master.For me, this seems to work correctly on linux x86_64, with
pkgsMusl,pkgsStaticandpkgsCross.aarch64-multiplatformbehaving as expected.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)