Skip to content

Xfce updates #223671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bobby285271 merged 6 commits into from
Mar 29, 2023
Merged

Xfce updates #223671

bobby285271 merged 6 commits into from
Mar 29, 2023

Conversation

@bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Mar 29, 2023 •
edited
Loading

Description of changes

Notably contains crash fix(es) for glib 2.76

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bobby285271
xfce.garcon: 4.18.0 -> 4.18.1
fad6f1f 
https://gitlab.xfce.org/xfce/garcon/-/compare/garcon-4.18.0...garcon-4.18.1
@bobby285271
xfce.libxfce4ui: 4.18.2 -> 4.18.3
ccc42e2 
https://gitlab.xfce.org/xfce/libxfce4ui/-/compare/libxfce4ui-4.18.2...libxfce4ui-4.18.3
@bobby285271
xfce.xfce4-panel: 4.18.2 -> 4.18.3
a9eaebb 
https://gitlab.xfce.org/xfce/xfce4-panel/-/compare/xfce4-panel-4.18.2...xfce4-panel-4.18.3
@bobby285271
xfce.xfce4-pulseaudio-plugin: 0.4.5 -> 0.4.6
228930c 
https://gitlab.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/-/compare/xfce4-pulseaudio-plugin-0.4.5...xfce4-pulseaudio-plugin-0.4.6
@bobby285271
xfce.xfce4-screensaver: 4.18.0 -> 4.18.1
fed8808 
https://gitlab.xfce.org/apps/xfce4-screensaver/-/compare/xfce4-screensaver-4.18.0...xfce4-screensaver-4.18.1
@bobby285271
xfce.xfce4-session: 4.18.1 -> 4.18.2
f94262a 
https://gitlab.xfce.org/xfce/xfce4-session/-/compare/xfce4-session-4.18.1...xfce4-session-4.18.2
@github-actions github-actions bot added the 6.topic: xfce The Xfce Desktop Environment label Mar 29, 2023
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

@ofborg test xfce

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 29, 2023
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

Rebuilt my laptop to f94262a with environment.sessionVariables."G_SLICE" = "always-malloc";.

@bobby285271 bobby285271 requested review from muscaln and romildo March 29, 2023 03:12
@bobby285271 bobby285271 marked this pull request as ready for review March 29, 2023 03:12
romildo
romildo previously approved these changes Mar 29, 2023
View reviewed changes
@romildo
Copy link
Contributor

romildo commented Mar 29, 2023

Result of nixpkgs-review pr 223671 run on x86_64-linux 1

1 package marked as broken and skipped:
  • xfce.thunar-bare
3 packages failed to build:
  • xfce.xfce4-embed-plugin
  • xfce.xfce4-namebar-plugin
  • xmonad_log_applet_xfce
88 packages built:
  • xfce.exo
  • xfce.exo.dev
  • xfce.garcon
  • xfce.garcon.dev
  • xfce.libxfce4ui
  • xfce.libxfce4ui.dev
  • xfce.orage
  • xfce.orage.dev
  • xfce.parole
  • xfce.parole.dev
  • xfce.ristretto
  • xfce.ristretto.dev
  • xfce.thunar
  • xfce.thunar-archive-plugin
  • xfce.thunar-archive-plugin.dev
  • xfce.thunar-dropbox-plugin
  • xfce.thunar-media-tags-plugin
  • xfce.thunar-media-tags-plugin.dev
  • xfce.thunar-volman
  • xfce.thunar-volman.dev
  • xfce.thunar.dev
  • xfce.xfburn
  • xfce.xfburn.dev
  • xfce.xfce4-appfinder
  • xfce.xfce4-appfinder.dev
  • xfce.xfce4-battery-plugin
  • xfce.xfce4-battery-plugin.dev
  • xfce.xfce4-clipman-plugin
  • xfce.xfce4-clipman-plugin.dev
  • xfce.xfce4-cpufreq-plugin
  • xfce.xfce4-cpufreq-plugin.dev
  • xfce.xfce4-cpugraph-plugin
  • xfce.xfce4-cpugraph-plugin.dev
  • xfce.xfce4-datetime-plugin
  • xfce.xfce4-datetime-plugin.dev
  • xfce.xfce4-dict
  • xfce.xfce4-dict.dev
  • xfce.xfce4-dockbarx-plugin
  • xfce.xfce4-eyes-plugin
  • xfce.xfce4-fsguard-plugin
  • xfce.xfce4-genmon-plugin
  • xfce.xfce4-i3-workspaces-plugin
  • xfce.xfce4-mailwatch-plugin
  • xfce.xfce4-mpc-plugin
  • xfce.xfce4-netload-plugin
  • xfce.xfce4-netload-plugin.dev
  • xfce.xfce4-notes-plugin
  • xfce.xfce4-notifyd
  • xfce.xfce4-notifyd.dev
  • xfce.xfce4-panel
  • xfce.xfce4-panel-profiles
  • xfce.xfce4-panel-profiles.dev
  • xfce.xfce4-panel.dev
  • xfce.xfce4-power-manager
  • xfce.xfce4-power-manager.dev
  • xfce.xfce4-pulseaudio-plugin
  • xfce.xfce4-pulseaudio-plugin.dev
  • xfce.xfce4-screensaver
  • xfce.xfce4-screensaver.dev
  • xfce.xfce4-screenshooter
  • xfce.xfce4-screenshooter.dev
  • xfce.xfce4-sensors-plugin
  • xfce.xfce4-session
  • xfce.xfce4-session.dev
  • xfce.xfce4-settings
  • xfce.xfce4-settings.dev
  • xfce.xfce4-systemload-plugin
  • xfce.xfce4-taskmanager
  • xfce.xfce4-taskmanager.dev
  • xfce.xfce4-terminal
  • xfce.xfce4-terminal.dev
  • xfce.xfce4-time-out-plugin
  • xfce.xfce4-time-out-plugin.dev
  • xfce.xfce4-timer-plugin
  • xfce.xfce4-verve-plugin
  • xfce.xfce4-verve-plugin.dev
  • xfce.xfce4-weather-plugin
  • xfce.xfce4-whiskermenu-plugin
  • xfce.xfce4-whiskermenu-plugin.dev
  • xfce.xfce4-windowck-plugin
  • xfce.xfce4-xkb-plugin
  • xfce.xfce4-xkb-plugin.dev
  • xfce.xfdashboard
  • xfce.xfdashboard.dev
  • xfce.xfdesktop
  • xfce.xfdesktop.dev
  • xfce.xfwm4
  • xfce.xfwm4.dev

@romildo romildo dismissed their stale review March 29, 2023 12:01

Check the failing builds

@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

@ofborg build xfce.xfce4-embed-plugin
@ofborg build xfce.xfce4-namebar-plugin
@ofborg build xmonad_log_applet_xfce

@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

Hmmm, I think they are marked as broken

@romildo
Copy link
Contributor

romildo commented Mar 29, 2023

Hmmm, I think they are marked as broken

They are marked as broken, indeed. I don't know why nixpkgs-review did not classify them as broken.

@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

Result of nixpkgs-review pr 223671 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • xfce.thunar-bare
  • xfce.xfce4-embed-plugin
  • xfce.xfce4-namebar-plugin
  • xmonad_log_applet_xfce
51 packages built:
  • xfce.exo
  • xfce.garcon
  • xfce.libxfce4ui
  • xfce.orage
  • xfce.parole
  • xfce.ristretto
  • xfce.thunar
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.thunar-media-tags-plugin
  • xfce.thunar-volman
  • xfce.xfburn
  • xfce.xfce4-appfinder
  • xfce.xfce4-battery-plugin
  • xfce.xfce4-clipman-plugin
  • xfce.xfce4-cpufreq-plugin
  • xfce.xfce4-cpugraph-plugin
  • xfce.xfce4-datetime-plugin
  • xfce.xfce4-dict
  • xfce.xfce4-dockbarx-plugin
  • xfce.xfce4-eyes-plugin
  • xfce.xfce4-fsguard-plugin
  • xfce.xfce4-genmon-plugin
  • xfce.xfce4-i3-workspaces-plugin
  • xfce.xfce4-mailwatch-plugin
  • xfce.xfce4-mpc-plugin
  • xfce.xfce4-netload-plugin
  • xfce.xfce4-notes-plugin
  • xfce.xfce4-notifyd
  • xfce.xfce4-panel
  • xfce.xfce4-panel-profiles
  • xfce.xfce4-power-manager
  • xfce.xfce4-pulseaudio-plugin
  • xfce.xfce4-screensaver
  • xfce.xfce4-screenshooter
  • xfce.xfce4-sensors-plugin
  • xfce.xfce4-session
  • xfce.xfce4-settings
  • xfce.xfce4-systemload-plugin
  • xfce.xfce4-taskmanager
  • xfce.xfce4-terminal
  • xfce.xfce4-time-out-plugin
  • xfce.xfce4-timer-plugin
  • xfce.xfce4-verve-plugin
  • xfce.xfce4-weather-plugin
  • xfce.xfce4-whiskermenu-plugin
  • xfce.xfce4-windowck-plugin
  • xfce.xfce4-xkb-plugin
  • xfce.xfdashboard
  • xfce.xfdesktop
  • xfce.xfwm4

@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

(The above one is generated by nixpkgs-review 2.8.0)

Are you interested in doing bisects right now since I have some $work to deal with and cannot do that fast 😿 ?

Since things work fine 2 weeks ago in #221278 (I pasted a nixpkgs-review in the opening), I would probably blame the nixpkgs-review update, which happened a week ago in #222211.

It sounds like using 2.8.0 with Mic92/nixpkgs-review@3193e60 backported (due to a 400 issue) things work fine. So we likely only need to bisect Mic92/nixpkgs-review@2.8.0...2.9.0.

@romildo
Copy link
Contributor

romildo commented Mar 29, 2023

Currently I have nixpkgs-review 2.9.0 on my system. But I am not interested in doing bisects now, as I am in hurry with other things.

@romildo romildo self-requested a review March 29, 2023 13:18
@bobby285271
Copy link
Member Author

bobby285271 commented Mar 29, 2023

Did not bisect, probably Mic92/nixpkgs-review#315 is the reason, passing --extra-nixpkgs-config '{ allowBroken = false; }' seems to work

@bobby285271 bobby285271 merged commit e02ad91 into NixOS:master Mar 29, 2023
@bobby285271 bobby285271 deleted the upd/xfce branch March 29, 2023 13:34
@bobby285271 bobby285271 mentioned this pull request Mar 30, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romildo romildo romildo approved these changes

@muscaln muscaln Awaiting requested review from muscaln

Assignees

No one assigned

Labels

6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobby285271 @romildo