cc-wrapper: fix inverted logic around fortify & fortify3 mutual exclusion#217394
Merged
risicle merged 1 commit intoNixOS:stagingfrom Feb 21, 2023
Merged
Conversation
13 tasks
risicle
added
the
1.severity: security
risicle
changed the title
fortify & fortify3 mutual exclusion
ofborg
bot
added
10.rebuild-darwin-stdenv
trofi
approved these changes
Feb 21, 2023
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Confirmed libomxil-bellagio now builds unmodified in staging.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Follow up to #212498. I will have to rely on someone else to test this (perhaps against #217390), because I don't have a built staging cached or the resources to build one quickly.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)