Skip to content

python3Packages.slack-bolt: init at 1.16.1#208906

Closed
jpetrucciani wants to merge 2 commits intoNixOS:masterfrom
jpetrucciani:add_slack-bolt
Closed

python3Packages.slack-bolt: init at 1.16.1#208906
jpetrucciani wants to merge 2 commits intoNixOS:masterfrom
jpetrucciani:add_slack-bolt

Conversation

@jpetrucciani
Copy link
Member

@jpetrucciani jpetrucciani commented Jan 3, 2023

Description of changes

I would like to include slack-bolt in nixpkgs to be able to create Slack bots and other applications using Slack's Bolt framework! This PR also includes adding boddle as a checkInput.

Previous PR for boddle here: #188832

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 3, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 3, 2023
@jpetrucciani jpetrucciani mentioned this pull request Jan 3, 2023
Closed
13 tasks
fabaff
fabaff reviewed Jan 4, 2023
View reviewed changes
pkgs/development/python-modules/boddle/default.nix Outdated
Copy link
Member

@fabaff fabaff Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we get tags.

@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jan 4, 2023

@fabaff thanks for the thorough review! I've made all the requested changes, and added a comment noting your issue in the boddle github repo!

@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jan 25, 2023 •
edited
Loading

This has switched checkInputs to nativeCheckInputs to satisfy the recent tree-wide change (#206742)!

@fabaff is the lack of boddle tags a blocker for this PR in general? or would this be mergeable without those?

@jpetrucciani jpetrucciani requested a review from fabaff February 10, 2023 17:47
@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jul 29, 2023

closing since #243593 was merged.

@jpetrucciani jpetrucciani deleted the add_slack-bolt branch July 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpetrucciani @fabaff