Skip to content

python3Packages.slack-bolt: init at 1.18.0#243593

Merged
samuela merged 3 commits intoNixOS:masterfrom
samuela:samuela/slack-bolt
Jul 21, 2023
Merged

python3Packages.slack-bolt: init at 1.18.0#243593
samuela merged 3 commits intoNixOS:masterfrom
samuela:samuela/slack-bolt

Conversation

@samuela
Copy link
Member

@samuela samuela commented Jul 15, 2023

Description of changes

Package the slack-bolt project. Also required fixing slack-sdk's build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

samuela added 3 commits July 15, 2023 00:50
`python3Packages.databases` is broken due to encode/databases#530. Luckily, it turns out that `databases` was not a necessary dependency anyways. See slackapi/python-slack-sdk#1388.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 15, 2023
@samuela samuela requested a review from fabaff July 15, 2023 05:51
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 15, 2023
@samuela
Copy link
Member Author

samuela commented Jul 17, 2023

if no one objects I'll merge tomorrow?

@samuela samuela merged commit dfc26ed into NixOS:master Jul 21, 2023
@samuela samuela deleted the samuela/slack-bolt branch July 21, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant