python3Packages.boddle: init at 0.2.9#188832
Closed
jpetrucciani wants to merge 1 commit intoNixOS:masterfrom
Closed
python3Packages.boddle: init at 0.2.9#188832jpetrucciani wants to merge 1 commit intoNixOS:masterfrom
jpetrucciani wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Contributor
It doesn't look like it has many tests, but it would be good to get them running seeing as it is a testing library. |
jpetrucciani
force-pushed
the
jacobi_add_boddle
branch
from
9ab8caf to
61cf07d
Compare
Member
Author
|
@risicle good call, i've changed it to load from github instead to include the tests! |
risicle
reviewed
Sep 4, 2022
| src = fetchFromGitHub { | ||
| owner = "keredson"; | ||
| repo = pname; | ||
| rev = "74413e4c5b39a37ea1694fab07b459ccd2998390"; |
Contributor
There was a problem hiding this comment.
Suggested change
| rev = "74413e4c5b39a37ea1694fab07b459ccd2998390"; | |
| # upstream doesn't tag releases | |
| rev = "74413e4c5b39a37ea1694fab07b459ccd2998390"; |
Suggest you open an issue upstream to suggest they start doing this too. There are a few reasons we dislike pointing at specific commit ids:
- it's not very transparent - there's no guarantee that the commit you're pointing at is even in one of upstream's branches
- it doesn't work with auto-updaters
Member
|
@ofborg build python310Packages.boddle |
13 tasks
Member
Author
|
Closing in favor of #208906 which is what I wanted boddle in nixpkgs for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I would like to include boddle in nixpkgs proper to assist in unit testing bottle based services!
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes