Skip to content

python310Packages.twisted: 22.8.0 -> 22.10.0 #201130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mweinelt merged 1 commit into from
Nov 14, 2022
Merged

python310Packages.twisted: 22.8.0 -> 22.10.0 #201130

mweinelt merged 1 commit into from
Nov 14, 2022

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Nov 14, 2022

What do we do about 22.05?

Description of changes

fixes CVE-2022-39348
https://github.com/twisted/twisted/releases/tag/twisted-22.10.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

cc @NixOS/nixos-release-managers

@dotlambda dotlambda added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 14, 2022
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 14, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 14, 2022
@dotlambda dotlambda changed the base branch from master to staging November 14, 2022 15:31
@mweinelt mweinelt merged commit 69f590d into NixOS:staging Nov 14, 2022
@mweinelt
Copy link
Member

mweinelt commented Nov 14, 2022

What do we do about 22.05?

Mangle the patches mentioned in the advisory.

@mweinelt mweinelt mentioned this pull request Nov 14, 2022
Merged
13 tasks
@dotlambda dotlambda deleted the twisted-22.10.0 branch November 15, 2022 01:32
SuperSandro2000
SuperSandro2000 reviewed Nov 15, 2022
View reviewed changes
pkgs/development/python-modules/twisted/default.nix
checkInputs = [
git
glibcLocales
hypothesis
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains why some tests failed when I tried to update but I couldn't find an error log so I had no clue.

@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

Successfully created backport PR #203401 for staging-22.11.

@vcunat
Copy link
Member

vcunat commented Dec 4, 2022

So, this broke the build/tests on aarch64-darwin:

(The other three platforms built OK on staging-next.)

@mweinelt mweinelt mentioned this pull request Dec 4, 2022
Merged
13 tasks
@vcunat
Copy link
Member

vcunat commented Dec 11, 2022 •
edited by dotlambda
Loading

This update broke:

It's not nice when security fixes bring incompatible changes (e.g. "deprecations and removals" in these release notes).

@dotlambda dotlambda mentioned this pull request Dec 12, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @mweinelt @vcunat @SuperSandro2000