Skip to content

python310Packages.foolscap: fix tests with Twisted 22.10.0 #205722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotlambda merged 1 commit into from
Dec 14, 2022
Merged

python310Packages.foolscap: fix tests with Twisted 22.10.0 #205722

dotlambda merged 1 commit into from
Dec 14, 2022

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Dec 12, 2022 •
edited
Loading

See #201130 (comment). Fixes the build on staging-next.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from vcunat December 12, 2022 06:40
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 12, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 12, 2022
@dotlambda dotlambda mentioned this pull request Dec 13, 2022
Closed
@dotlambda dotlambda merged commit 07fa215 into NixOS:staging-next Dec 14, 2022
@dotlambda dotlambda deleted the foolscap-fix branch December 14, 2022 00:07
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

Successfully created backport PR #205986 for release-22.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dotlambda