Skip to content

[Backport staging-22.11] python310Packages.twisted: 22.8.0 -> 22.10.0#203401

Merged
vcunat merged 2 commits intostaging-next-22.11from
backport-201130-to-staging-22.11
Dec 4, 2022
Merged

[Backport staging-22.11] python310Packages.twisted: 22.8.0 -> 22.10.0#203401
vcunat merged 2 commits intostaging-next-22.11from
backport-201130-to-staging-22.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 28, 2022

Bot-based backport to staging-22.11, triggered by a label in #201130.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

@ofborg ofborg bot requested a review from SuperSandro2000 November 28, 2022 04:57
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Nov 28, 2022
@risicle
Copy link
Contributor

risicle commented Nov 29, 2022

@ofborg build buildbot

@risicle
Copy link
Contributor

risicle commented Nov 29, 2022

Buildbot on x86_64 linux is the only package I'm newly having trouble building with this across macos 10.15, nixos x86_64 & aarch64-linux.

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 3, 2022
@vcunat
Copy link
Member

vcunat commented Dec 4, 2022

  • breaks build on aarch64-darwin

@vcunat vcunat marked this pull request as draft December 4, 2022 08:28
They all fail for the same reason:

```
[ERROR]
Traceback (most recent call last):
  File "/nix/store/xz6krlmwsc15z96p7hgcvssmx848hvq0-python3.10-twisted-22.10.0/lib/python3.10/site-packages/twisted/internet/test/test_posixbase.py", line 55, in tearDown
    self.assertEqual(
  File "/nix/store/xz6krlmwsc15z96p7hgcvssmx848hvq0-python3.10-twisted-22.10.0/lib/python3.10/site-packages/twisted/trial/_synctest.py", line 441, in assertEqual
    super().assertEqual(first, second, msg)
  File "/nix/store/70c1n7i4c90dn4iys0myy30yfxmlsza7-python3-3.10.8/lib/python3.10/unittest/case.py", line 845, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/nix/store/70c1n7i4c90dn4iys0myy30yfxmlsza7-python3-3.10.8/lib/python3.10/unittest/case.py", line 838, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 3 != 0 : Warnings found at the end of the test:
[{'message': 'unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>', 'category': <class 'ResourceWarning'>, 'filename': '/nix/store/70c1n7i4c90dn4iys0myy30yfxmlsza7-python3-3.10.8/lib/python3.10/asyncio/base_events.py', 'lineno': 688}, {'message': 'unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>', 'category': <class 'ResourceWarning'>, 'filename': '/nix/store/70c1n7i4c90dn4iys0myy30yfxmlsza7-python3-3.10.8/lib/python3.10/asyncio/base_events.py', 'lineno': 688}, {'message': 'unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>', 'category': <class 'ResourceWarning'>, 'filename': '/nix/store/70c1n7i4c90dn4iys0myy30yfxmlsza7-python3-3.10.8/lib/python3.10/asyncio/base_events.py', 'lineno': 688}]

twisted.internet.test.test_posixbase.PosixReactorBaseTests.test_removeAllSkipsInternalReaders
```

(cherry picked from commit a705dca)
@mweinelt mweinelt marked this pull request as ready for review December 4, 2022 14:28
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 4, 2022
@mweinelt
Copy link
Member

mweinelt commented Dec 4, 2022

Disabled a few tests on staging-next and backported that change.

@vcunat vcunat changed the base branch from staging-22.11 to staging-next-22.11 December 4, 2022 17:24
@vcunat vcunat merged commit 06f4868 into staging-next-22.11 Dec 4, 2022
@vcunat vcunat deleted the backport-201130-to-staging-22.11 branch December 4, 2022 17:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants