Skip to content

nixosTests.cagebreak: fix by enabling udisks2#189415

Merged
dasJ merged 1 commit intoNixOS:masterfrom
alyssais:cagebreak
Sep 2, 2022
Merged

nixosTests.cagebreak: fix by enabling udisks2#189415
dasJ merged 1 commit intoNixOS:masterfrom
alyssais:cagebreak

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Sep 2, 2022

Description of changes

This test was broken when services.udisks2.enable's default was changed to false.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This test was broken when services.udisks2.enable's default was
changed to false.

Fixes: f763710 ("nixos/udisks2: don't enable by default")
@alyssais alyssais requested review from ajs124 and primeos September 2, 2022 08:48
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Sep 2, 2022
@alyssais alyssais mentioned this pull request Sep 2, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 2, 2022
@alyssais
Copy link
Member Author

alyssais commented Sep 2, 2022

@ofborg test cagebreak

@dasJ dasJ merged commit da141d2 into NixOS:master Sep 2, 2022
@alyssais alyssais deleted the cagebreak branch September 2, 2022 18:12
@primeos
Copy link
Member

primeos commented Sep 3, 2022

Thanks for the test fix :) However, only polkit is required for cagebreak. I've opened a followup PR for that: #189589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants