nixos/tests/cagebreak: Enable just polkit instead of udisks2#189589
Merged
primeos merged 1 commit intoNixOS:masterfrom Sep 3, 2022
Merged
nixos/tests/cagebreak: Enable just polkit instead of udisks2#189589primeos merged 1 commit intoNixOS:masterfrom
primeos merged 1 commit intoNixOS:masterfrom
Conversation
The udisks2 service was enabled to fix the test in (c5ebec7). However, cagebreak doesn't require udisks2, just polkit (which the udisks2 module enables and which is why the cagebreak test broke after the udisks2 module was disabled by default). I've documented why polkit is required in this PR: NixOS#156858 In this case the "dependency" chain is basically cagebreak -> wlroots -> libseat -> logind (with polkit support) -> polkit.
github-actions
bot
added
the
6.topic: nixos
Member
Author
|
@ofborg test cagebreak |
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The udisks2 service was enabled to fix the test in (c5ebec7).
However, cagebreak doesn't require udisks2, just polkit (which the
udisks2 module enables and which is why the cagebreak test broke after
the udisks2 module was disabled by default).
I've documented why polkit is required in this PR:
#156858
In this case the "dependency" chain is basically cagebreak -> wlroots ->
libseat -> logind (with polkit support) -> polkit.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes