nixos/udisks2: don't enable by default#186028
Merged
dasJ merged 2 commits intoNixOS:masterfrom Aug 11, 2022
Merged
Conversation
This was enabled by default in 18a7ce7 with the reason that it would be "useful regardless of the desktop environment.", which I'm not arguing against. The reason why this should not be enabled by default is that there are a lot of systems that NixOS runs on that are not desktop systems. Users on such systems most likely do not want or need this feature and could even consider this an antifeature. Furthermore, it is surprising to them to find out that they have this enabled on their systems. They might be even more surprised to find that they have polkit enabled by default, which was a default that was flipped in a813be0. For some discussion as to why see NixOS#156858. Evidently, this default is not only surprising to users, but also module developers, as most if not all modules for desktop environments already explicity set services.udisks2.enable = true; which they don't need to right now.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
mweinelt
approved these changes
Aug 11, 2022
dasJ
approved these changes
Aug 11, 2022
fpletz
approved these changes
Aug 11, 2022
Member
There was a problem hiding this comment.
👍 since I have it disabled by default on my systems for years.
After looking through the desktop manager modules, I noticed that the ones that do not specify udisks2 and most likely are using it (MATE, lxqt) enable gvfs which at least can use udisks2. My suggestion would be to enable udisks2 in the services.gvfs module for minimal impact on existing desktop users.
bobby285271
added
the
12.approvals: 3+
can be used by gvfs and is disabled by default after f763710
2 tasks
2 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/lightdm-dwm-not-working/21147/6 |
Member
|
This has broken some NixOS tests. At least |
13 tasks
jlesquembre
added a commit
to jlesquembre/dotfiles
that referenced
this pull request
Oct 8, 2022
udisks2 was enabled by default, but now it's not. See: NixOS/nixpkgs#186028 nix-community/home-manager#3153
somasis
added a commit
to somasis/puter
that referenced
this pull request
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This was enabled by default in 18a7ce7
with the reason that it would be "useful regardless of the desktop
environment.", which I'm not arguing against.
The reason why this should not be enabled by default is that there are a
lot of systems that NixOS runs on that are not desktop systems.
Users on such systems most likely do not want or need this feature and
could even consider this an antifeature.
Furthermore, it is surprising to them to find out that they have this
enabled on their systems.
They might be even more surprised to find that they have polkit enabled
by default, which was a default that was flipped in
a813be0, for some discussion as to why
see #156858.
Evidently, this default is not only surprising to users, but also module
developers, as most if not all modules for desktop environments
already explicity set services.udisks2.enable = true; which they don't
need to right now.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes