Skip to content

python3Packages.boddle: init at 0.2.9 #188832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpetrucciani wants to merge 1 commit into from
Closed

python3Packages.boddle: init at 0.2.9 #188832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions pkgs/development/python-modules/boddle/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{ lib
, buildPythonPackage
, fetchFromGitHub
, pythonOlder
, bottle
}:

buildPythonPackage rec {
pname = "boddle";
version = "0.2.9";
disabled = pythonOlder "3.7";

src = fetchFromGitHub {
owner = "keredson";
repo = pname;
rev = "74413e4c5b39a37ea1694fab07b459ccd2998390";
Copy link
Contributor

@risicle risicle Sep 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "74413e4c5b39a37ea1694fab07b459ccd2998390";
# upstream doesn't tag releases
rev = "74413e4c5b39a37ea1694fab07b459ccd2998390";

Suggest you open an issue upstream to suggest they start doing this too. There are a few reasons we dislike pointing at specific commit ids:

  • it's not very transparent - there's no guarantee that the commit you're pointing at is even in one of upstream's branches
  • it doesn't work with auto-updaters

sha256 = "sha256-iyxgdUM3NEbDaRd8ogCsxyNPF0nMuIV2S4FiFAZJXrY=";
};

propagatedBuildInputs = [ bottle ];

pythonImportsCheck = [
"boddle"
];

meta = with lib; {
description = "Unit testing tool for Python's bottle library";
homepage = "https://github.com/keredson/boddle";
license = licenses.lgpl21;
maintainers = with maintainers; [ jpetrucciani ];
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/python-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,8 @@ in {

bme680 = callPackage ../development/python-modules/bme680 { };

boddle = callPackage ../development/python-modules/boddle { };

bokeh = callPackage ../development/python-modules/bokeh { };

boltons = callPackage ../development/python-modules/boltons { };
Expand Down