Skip to content

stratis-cli: init at 3.2.0#186940

Merged
onny merged 9 commits intoNixOS:masterfrom
NickCao:stratis-cli
Sep 16, 2022
Merged

stratis-cli: init at 3.2.0#186940
onny merged 9 commits intoNixOS:masterfrom
NickCao:stratis-cli

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Aug 16, 2022

Description of changes

To be used with #184675

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 16, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 16, 2022
onny
onny reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@onny onny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great contribution! Please check if you could enable more tests :)

@NickCao
Copy link
Member Author

NickCao commented Aug 24, 2022

The tests for stratis-cli itself depends on stratisd, thus left out for now.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 12, 2022
@NickCao
Copy link
Member Author

NickCao commented Sep 12, 2022

Password encryption support depends on #184770, thus not tested.

@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 12, 2022
@onny
Copy link
Contributor

onny commented Sep 16, 2022

Result of nixpkgs-review pr 186940 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
5 packages failed to build:
  • python310Packages.dbus-python-client-gen
  • python310Packages.into-dbus-python
  • python39Packages.dbus-python-client-gen
  • python39Packages.into-dbus-python
  • stratis-cli
4 packages built:
  • python310Packages.dbus-signature-pyparsing
  • python310Packages.hs-dbus-signature
  • python39Packages.dbus-signature-pyparsing
  • python39Packages.hs-dbus-signature

@onny
Copy link
Contributor

onny commented Sep 16, 2022

One dependency fails to build because one test took too long. I need to figure out how to fix this on my machine :)

@NickCao
Copy link
Member Author

NickCao commented Sep 16, 2022

Result of nixpkgs-review pr 186940 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
9 packages built:
  • python310Packages.dbus-python-client-gen
  • python310Packages.dbus-signature-pyparsing
  • python310Packages.hs-dbus-signature
  • python310Packages.into-dbus-python
  • python39Packages.dbus-python-client-gen
  • python39Packages.dbus-signature-pyparsing
  • python39Packages.hs-dbus-signature
  • python39Packages.into-dbus-python
  • stratis-cli

@onny onny merged commit 22c17bd into NixOS:master Sep 16, 2022
@onny
Copy link
Contributor

onny commented Sep 16, 2022

Thank you, nice work :)

@NickCao NickCao deleted the stratis-cli branch September 16, 2022 11:41
SuperSandro2000
SuperSandro2000 reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages are missing pythonImportsChecks

@NickCao
Copy link
Member Author

NickCao commented Sep 16, 2022 •
edited
Loading

Are imports checks still required if pytests are present?

@NickCao NickCao mentioned this pull request Sep 16, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onny onny onny left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NickCao @onny @SuperSandro2000 @jonringer