Skip to content

stratisd: init at 3.2.2#184675

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
NickCao:stratisd
Aug 24, 2022
Merged

stratisd: init at 3.2.2#184675
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
NickCao:stratisd

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Aug 2, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member Author

NickCao commented Aug 2, 2022

to test:

{
  systemd.packages = [ pkgs.stratisd ];
  services.dbus.packages = [ pkgs.stratisd ];
  services.udev.packages = [ pkgs.stratisd ];
  systemd.services.stratisd.wantedBy = [ "sysinit.target" ];
}

A WIP stratis-cli is at https://github.com/NickCao/nixpkgs/tree/stratis-cli

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 2, 2022
@NickCao NickCao force-pushed the stratisd branch 5 times, most recently from f877c7d to 6bb7d21 Compare August 2, 2022 16:14
@SuperSandro2000
Copy link
Member

to test:

{
  systemd.packages = [ pkgs.stratisd ];
  services.dbus.packages = [ pkgs.stratisd ];
  services.udev.packages = [ pkgs.stratisd ];
  systemd.services.stratisd.wantedBy = [ "sysinit.target" ];
}

We should move that into a nixos module, right?

@NickCao
Copy link
Member Author

NickCao commented Aug 3, 2022

We should move that into a nixos module, right?

I'd like to take care of that and add some tests later (when stratis-ctl is ready).

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks solid

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that this will not work since both variables are fixed output derivations

@NickCao
Copy link
Member Author

NickCao commented Aug 4, 2022

I just noticed that this will not work since both variables are fixed output derivations

There are works on making these fetchers overriable: #158018

@SuperSandro2000
Copy link
Member

Can we bush that back until it is figured out how to do that? Right now it is really vague and nothing concrete. Maybe this gets so big that we get a treewide change and convert everything? We don't know yet and I would like to avoid compatibility code for something that might come eventually.

@NickCao NickCao changed the title stratisd: init at 3.2.1 stratisd: init at 3.2.2 Aug 24, 2022
@SuperSandro2000 SuperSandro2000 merged commit 69be1ec into NixOS:master Aug 24, 2022
@NickCao NickCao deleted the stratisd branch August 24, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants