Skip to content

stratis-cli: add checks to itself and various dependencies#191501

Merged
superherointj merged 5 commits intoNixOS:masterfrom
NickCao:import-checks
Sep 17, 2022
Merged

stratis-cli: add checks to itself and various dependencies#191501
superherointj merged 5 commits intoNixOS:masterfrom
NickCao:import-checks

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Sep 16, 2022

Description of changes

Addresses #186940 (review)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 16, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 16, 2022
@superherointj
Copy link
Contributor

superherointj commented Sep 17, 2022

Result of nixpkgs-review pr 191501 run on x86_64-linux 1

9 packages built:
  • python310Packages.dbus-python-client-gen
  • python310Packages.dbus-signature-pyparsing
  • python310Packages.hs-dbus-signature
  • python310Packages.into-dbus-python
  • python39Packages.dbus-python-client-gen
  • python39Packages.dbus-signature-pyparsing
  • python39Packages.hs-dbus-signature
  • python39Packages.into-dbus-python
  • stratis-cli

@superherointj superherointj merged commit 90cf59e into NixOS:master Sep 17, 2022
@NickCao NickCao deleted the import-checks branch September 18, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

1 more reviewer

@superherointj superherointj superherointj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickCao @superherointj