Reflect changes to LIBEXECDIR and UNITEXECDIR in systemd units#3064
Merged
mulkieran merged 1 commit intostratis-storage:masterfrom Aug 2, 2022
Merged
Reflect changes to LIBEXECDIR and UNITEXECDIR in systemd units#3064mulkieran merged 1 commit intostratis-storage:masterfrom
mulkieran merged 1 commit intostratis-storage:masterfrom
Conversation
mulkieran
approved these changes
Aug 2, 2022
Contributor
|
Looks reasonable to me. Templating systemd units like this is quite common. It'd be good to have some motivation in the commit message; I'm assuming this is for e.g. Debian where there isn't a libexecdir as is? |
Contributor
Author
|
I'm utilizing these changes for packaging in nixpkgs: NixOS/nixpkgs#184675, in general all the hardcoded paths should be parametrizable to accommodate non-fhs distributions (NixOS or Guix #1556, for example) or distributions with their own policies for where these files should go. |
To ease packaging for non-FHS distributions like NixOS or Guix
jbaublitz
approved these changes
Aug 2, 2022
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Dec 4, 2023
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Dec 4, 2023
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Jan 4, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Jan 4, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Jan 22, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Sep 23, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit b38b962)
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Sep 23, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit b38b962)
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Sep 24, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit b38b962)
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Sep 25, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit b38b962)
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Sep 27, 2024
This step was done partially in a prior PR, this just completes that. See: stratis-storage#3064 Signed-off-by: mulhern <amulhern@redhat.com> (cherry picked from commit b38b962)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.