teams: 1.4.00.26453 -> 1.5.00.10453

[srhb]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[liff]

I don’t currently use Teams so have not tested properly but running the binary works.

[liff]

@srhb I realized that the hash of the macOS package should have been updated as well; fixed in #171295.

[srhb]

Sorry, completely missed there were two hashes. I'll merge tomorrow. Thanks for the heads-up. :)

[drupol]

Hey hi!

I'm not able to do nixos-rebuild with the latest nixos-unstable commit 2a3aac4.

Its blocking when installing Teams, do you have any clue what it could be ?

$ sudo nixos-rebuild switch --upgrade-all --flake github:drupol/nixos-x260                                                                                                                            
building the system configuration...
error: builder for '/nix/store/p928mj0z0qjm7im0i6gafckiylxpnlvp-teams-1.5.00.10453.drv' failed with exit code 1;
       last 10 log lines:
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/native-utils/build/Release/native-utils.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/slimcore/bin/trouter-client.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/slimcore/bin/slimcore.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/slimcore/bin/sharing-indicator.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/slimcore/bin/platform.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/@microsoft/fasttext-languagedetector/build/Release/fastText-languagedetector.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/media-hid/build/Release/media-hid.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/@msteams/node-locale-info-provider/build/Release/node-locale-info-provider.node
       > Adding runtime dependencies to RPATH of Node module /nix/store/4g2smhfmjq3grq8ac0zwgl8jip9p4rb3-teams-1.5.00.10453/opt/teams/resources/app.asar.unpacked/node_modules/@msteams/electron-modules-package-utils/build/Release/package-utils.node
       > consumeEntire(): ERROR: Input null bytes, won't process
       For full logs, run 'nix log /nix/store/p928mj0z0qjm7im0i6gafckiylxpnlvp-teams-1.5.00.10453.drv'.
error: 1 dependencies of derivation '/nix/store/g09zxhng4v08bahjhlq3iaqhrav63yw5-man-paths.drv' failed to build
error: 1 dependencies of derivation '/nix/store/3q9pp8i9bl8mkkyn2wmw1wkhhqihiqca-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/mk1c082rmrcfzvapwls3l3qc2gyh7inn-teams-1.5.00.10453_fish-completions.drv' failed to build
error: 1 dependencies of derivation '/nix/store/dvf6y7s126yg4z6a0p4g61kagj4w6hqk-nixos-system-x260-22.05.20220509.2a3aac4.drv' failed to build
$                       

Looks like the source of the erorr message comes from here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh#L748

[srhb]

No, but I'm fairly certain it's not related to this update. I'll try and remember to bisect later, but I think it might be crossing a staging merge boundary, so probably some global update.

[srhb]

Looks similar to what #172315 fixes

[ncfavier]

nixpkgs/pkgs/applications/networking/instant-messengers/teams/default.nix

Lines 123 to 126 in 039f1fe

	# fix for https://docs.microsoft.com/en-us/answers/questions/298724/open-teams-meeting-link-on-linux-doens39t-work.html?childToView=309406#comment-309406
	# while we create the wrapper ourselves, gappsWrapperArgs leads to the same issue
	# another option would be to introduce gappsWrapperAppendedArgs, to allow control of positioning
	substituteInPlace "$out/bin/teams" --replace '.teams-wrapped" --disable-namespace-sandbox --disable-setuid-sandbox "$@"' '.teams-wrapped" "$@" --disable-namespace-sandbox --disable-setuid-sandbox'

This relies on the wrapper being a shell script, which was changed by #164163.

[ncfavier]

Fixed in #172319