Merged
Conversation
We can't rely on the wrapper being a shell script, so we make our own wrapper to append the needed args.
13 tasks
drupol
approved these changes
May 10, 2022
srhb
approved these changes
May 10, 2022
Contributor
srhb
left a comment
srhb
left a comment
There was a problem hiding this comment.
Builds and runs with basic functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170863 (comment)
We can't rely on the wrapper being a shell script, so we make our own wrapper to append the needed args.
Making a note here that it would be useful to have
--append-flagsin both implementations ofmakeWrapper.