Skip to content

teams: fix source hash of 1.5.00.10453 on Darwin#171295

Merged
srhb merged 1 commit intoNixOS:masterfrom
liff:teams/update-darwin-hash
May 3, 2022
Merged

teams: fix source hash of 1.5.00.10453 on Darwin#171295
srhb merged 1 commit intoNixOS:masterfrom
liff:teams/update-darwin-hash

Conversation

@liff
Copy link
Contributor

@liff liff commented May 2, 2022

Description of changes

Teams was upgraded to 1.5.00.10453 in #170863 but that PR missed the update of the hash of the source package on Darwin platforms.

I am unable to build and test this but the hash should be correct.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 2, 2022
@liff liff mentioned this pull request May 2, 2022
13 tasks
@ofborg ofborg bot requested a review from tricktron May 2, 2022 18:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 2, 2022
@tricktron
Copy link
Member

Result of nixpkgs-review pr 171295 run on aarch64-darwin 1

1 package built:
  • teams

Copy link
Member

@tricktron tricktron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srhb srhb merged commit 4014d68 into NixOS:master May 3, 2022
@srhb
Copy link
Contributor

srhb commented May 3, 2022

Thanks!

@liff liff deleted the teams/update-darwin-hash branch November 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants