Skip to content

libsForQt5.qt5-qca_2_3_2: add as darwin-compatible alternative for qt5-qca#168506

Merged
ttuegel merged 2 commits intoNixOS:masterfrom
willcohen:qca-darwin
Apr 13, 2022
Merged

libsForQt5.qt5-qca_2_3_2: add as darwin-compatible alternative for qt5-qca#168506
ttuegel merged 2 commits intoNixOS:masterfrom
willcohen:qca-darwin

Conversation

@willcohen
Copy link
Contributor

Description of changes

Noticed after #168159, qt5-qca 2.3.4 depends on Qt 5.15, which doesn't work on darwin.
Introduce a new qt5-qca_2_3_2, which still works on Qt 5.12 (and, therefore, still works on darwin), providing a path to enable Qt apps on darwin pending #101229, which will be needed before fixing Qt 5.15 on darwin.

@ttuegel

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 13, 2022
@willcohen willcohen changed the title Qca darwin libsForQt5.qca-qt5: fix build on darwin Apr 13, 2022
@willcohen willcohen changed the title libsForQt5.qca-qt5: fix build on darwin libsForQt5.qt5-qca_2_3_2: add as darwin-compatible alternative for qt5-qca Apr 13, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 13, 2022
@ofborg ofborg bot requested a review from ttuegel April 13, 2022 16:05
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 13, 2022
@ttuegel ttuegel merged commit 0c1bb90 into NixOS:master Apr 13, 2022
@ttuegel
Copy link
Member

ttuegel commented Apr 13, 2022

Thanks!

@willcohen willcohen deleted the qca-darwin branch April 13, 2022 16:47
@willcohen
Copy link
Contributor Author

Thanks for the quick turnaround!

@ajs124 ajs124 mentioned this pull request Nov 3, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants