libsForQt5.qca-qt5: 2.3.1 -> 2.3.4

[ajs124]

Description of changes

Upstream release(s).
Allows us to drop the patch and fixes openssl 3.0 compatibility (#150093)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ttuegel]

Thanks!

[willcohen]

Bumping to a version that requires Qt 5.14 means that this currently breaks on macOS:

nix-build $NIXPKGS -A libsForQt5.qca-qt5
this derivation will be built:
  /nix/store/28hikp584svkhsw2951sadkwnds9pss6-qca-qt5-2.3.4.drv
building '/nix/store/28hikp584svkhsw2951sadkwnds9pss6-qca-qt5-2.3.4.drv'...
qtPreHook
unpacking sources
unpacking source archive /nix/store/qm24k7wkjhr162wpxwmihdxzy54lirbq-qca-2.3.4.tar.xz
source root is qca-2.3.4
setting SOURCE_DATE_EPOCH to timestamp 1631623291 of file qca-2.3.4/unittest/velox/veloxunittest.cpp
patching sources
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/share/doc/qca-qt5 -DCMAKE_INSTALL_INFODIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/pwhphirdivv0f3zylhq20mvc0kk5m9i2-cctools-binutils-darwin-949.0.1/bin/strip -DCMAKE_RANLIB=/nix/store/pwhphirdivv0f3zylhq20mvc0kk5m9i2-cctools-binutils-darwin-949.0.1/bin/ranlib -DCMAKE_AR=/nix/store/pwhphirdivv0f3zylhq20mvc0kk5m9i2-cctools-binutils-darwin-949.0.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/6jxrcfzg67s2v4m6b36b2pmsgxkacgb7-qca-qt5-2.3.4 -Dqca_CERTSTORE=/etc/ssl/certs/ca-certificates.crt 
-- The C compiler identification is Clang 11.1.0
-- The CXX compiler identification is Clang 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/fmsdw4x41v6w5a1inazb28ryz3znxk4c-clang-wrapper-11.1.0/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/fmsdw4x41v6w5a1inazb28ryz3znxk4c-clang-wrapper-11.1.0/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Deprecation Warning at CMakeLists.txt:19 (cmake_policy):
  The OLD behavior for policy CMP0042 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) 
-- Building Qt 5 version
CMake Error at CMakeLists.txt:53 (find_package):
  Could not find a configuration file for package "Qt5" that is compatible
  with requested version "5.14".

  The following configuration files were considered but not accepted:

    /nix/store/ya77a7msnl6gqbj9vra22knby0km0vxp-qtbase-5.12.10-dev/lib/cmake/Qt5/Qt5Config.cmake, version: 5.12.10



-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-qca-qt5-2.3.4.drv-0/qca-2.3.4/build/CMakeFiles/CMakeOutput.log".
error: builder for '/nix/store/28hikp584svkhsw2951sadkwnds9pss6-qca-qt5-2.3.4.drv' failed with exit code 1;
       last 10 log lines:
       >   with requested version "5.14".
       >
       >   The following configuration files were considered but not accepted:
       >
       >     /nix/store/ya77a7msnl6gqbj9vra22knby0km0vxp-qtbase-5.12.10-dev/lib/cmake/Qt5/Qt5Config.cmake, version: 5.12.10
       >
       >
       > 
       > -- Configuring incomplete, errors occurred!
       > See also "/tmp/nix-build-qca-qt5-2.3.4.drv-0/qca-2.3.4/build/CMakeFiles/CMakeOutput.log".
       For full logs, run 'nix log /nix/store/28hikp584svkhsw2951sadkwnds9pss6-qca-qt5-2.3.4.drv'.

[willcohen]

@ttuegel given #108129, does it make sense to include a previous version for darwin compatibility, rather than holding this version back indefinitely?

[ttuegel]

Someone could add back the older version of this package or fix the Qt 5.15 packages on Darwin. One way or another, we need someone to step up as a Darwin maintainer for Qt, because we can't be held to three year old versions of everything just for the sake of that platform.

[willcohen]

Understood -- the macOS SDK issue is definitely becoming a real drag, particularly for anything relying on Qt! Per your recommendation, I assume just creating a 2.3.2 derivation and marking the current one as broken means that the majority of users can just ignore the darwin need for an old version, while darwin sorts out its own issues.