Skip to content

libsForQt5.qca-qt5_2_3_2: drop#197310

Merged
ajs124 merged 1 commit intoNixOS:masterfrom
NickCao:qca-drop
Nov 4, 2022
Merged

libsForQt5.qca-qt5_2_3_2: drop#197310
ajs124 merged 1 commit intoNixOS:masterfrom
NickCao:qca-drop

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Oct 23, 2022

Description of changes

There seems to be no reference to it now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 23, 2022
@ajs124
Copy link
Member

ajs124 commented Nov 3, 2022

We should also drop the file then. Actually, you might be able to just revert 252458b.

This was introduced in #168506, but a search with git log -p -Gqca-qt5_2_3_2 does not show that it was ever used in nixpkgs.

cc @ttuegel @willcohen

Copy link
Contributor

@willcohen willcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages that might have used this are still broken on my end, so you correctly note it's not actually used anymore. I don't even have an intel mac anymore, so the SDK being held back doesn't affect me as much as it once did -- if I can get things working on aarch and qt 5.15+, I think that's enough. In a worst case scenario, I suppose it can be re-added again down the line.

@ajs124 ajs124 merged commit 83013c8 into NixOS:master Nov 4, 2022
@NickCao NickCao deleted the qca-drop branch November 4, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants