ocamlPackages.findlib: don't wait configurePhase to set OCAMLFIND_DESTDIR#152276
Merged
symphorien merged 2 commits intoNixOS:stagingfrom Jan 23, 2022
Merged
ocamlPackages.findlib: don't wait configurePhase to set OCAMLFIND_DESTDIR#152276symphorien merged 2 commits intoNixOS:stagingfrom
symphorien merged 2 commits intoNixOS:stagingfrom
Conversation
…TDIR this fixes ocamlfind printconf destdir inside nix-shell fixes NixOS#152028 the regression was introduced by a3ab43d which was meant to fix building ocamlPackages.ocamlbuild with strictDeps. This commit keeps ocamlbuild building.
sternenseemann
approved these changes
Jan 9, 2022
allows to use configurePhase in nix-shell
sternenseemann
approved these changes
Jan 23, 2022
Contributor
|
Bisect says this change broke |
Contributor
|
Probably because buildPhase = "make all opt CPPFLAGS=-Wno-error";
installPhase = "make install-opt"; |
Contributor
|
Proposed fix as #156825 |
This was referenced Feb 11, 2022
vbgl
added a commit
to vbgl/nixpkgs
that referenced
this pull request
Feb 25, 2022
This package has been unmaintained upstream for years and broken in nixpkgs by 9a77836 in NixOS#152276.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes ocamlfind printconf destdir inside nix-shell
fixes #152028
the regression was introduced by a3ab43d which was meant to fix building ocamlPackages.ocamlbuild with strictDeps. This commit keeps ocamlbuild building.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes