Skip to content

Comments

ocamlPackages.pycaml: remove at 0.82-14#161836

Merged
vbgl merged 1 commit intoNixOS:masterfrom
vbgl:ocaml-pycaml-remove
Feb 26, 2022
Merged

ocamlPackages.pycaml: remove at 0.82-14#161836
vbgl merged 1 commit intoNixOS:masterfrom
vbgl:ocaml-pycaml-remove

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 25, 2022

Motivation for this change

This package has been unmaintained upstream for years and broken in
nixpkgs by 9a77836 in #152276 (cc @symphorien).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vbgl
ocamlPackages.pycaml: remove at 0.82-14
d63d523 
This package has been unmaintained upstream for years and broken in
nixpkgs by 9a77836 in NixOS#152276.
@vbgl vbgl added 8.has: clean-up This PR removes packages or removes other cruft 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Feb 25, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 25, 2022
symphorien
symphorien approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway people attempting to remove python2 would have done that soon.

@vbgl vbgl merged commit 3bcb49a into NixOS:master Feb 26, 2022
@vbgl vbgl deleted the ocaml-pycaml-remove branch February 26, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@symphorien symphorien symphorien approved these changes

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbgl @symphorien