Skip to content

Comments

ocamlPackages.{piqi,piqi-ocaml,bap}: fix build#159201

Merged
symphorien merged 3 commits intoNixOS:masterfrom
vbgl:ocaml-piqi-fix
Feb 11, 2022
Merged

ocamlPackages.{piqi,piqi-ocaml,bap}: fix build#159201
symphorien merged 3 commits intoNixOS:masterfrom
vbgl:ocaml-piqi-fix

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 11, 2022

Motivation for this change

These packages have been broken by 9a77836 (#152276).
cc @symphorien.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vbgl vbgl added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Feb 11, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 11, 2022
@symphorien symphorien merged commit 0f661f8 into NixOS:master Feb 11, 2022
@vbgl vbgl deleted the ocaml-piqi-fix branch February 11, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants