Skip to content

darwin.postFixupSignHook: use absolute path to codesign_allocate#148282

Closed
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann:codesign-hook-abs-path
Closed

darwin.postFixupSignHook: use absolute path to codesign_allocate#148282
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann:codesign-hook-abs-path

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Dec 2, 2021

Motivation for this change

Eliminate the assumption that codesign_allocate is in PATH when running the hook. which breaks the haskell writers atm: https://hydra.nixos.org/build/159988248.

Untested so far.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

sternenseemann commented Dec 2, 2021

@ofborg build pkgsCross.aarch64-darwin.hello hello

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 2, 2021
@sternenseemann sternenseemann mentioned this pull request Jan 3, 2022
Closed
13 tasks
@domenkozar
Copy link
Member

domenkozar commented Jan 3, 2022

@ofborg build tests.haskell.writers

@nixos-discourse
Copy link

nixos-discourse commented Jan 6, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/6

@sternenseemann
Copy link
Member Author

sternenseemann commented Jan 9, 2022

This is broken apparently:

output '/nix/store/6c0d8s1q70dbr73d7rjvlkvi1hlv3bnh-bootstrap-stage2-stdenv-darwin' is not allowed to refer to the following paths:
  /nix/store/0a7jd4wv0jicfn9czi136rir8wp6xnhm-cctools-port-949.0.1
  /nix/store/qwjr0yyapjjfcbw2mqp0ni97dbccjv12-ncurses-6.2
  /nix/store/xw2gjbxp31c01flxgnahsid2b0iva9sa-libtapi-1100.0.11

@sternenseemann sternenseemann marked this pull request as draft January 9, 2022 22:39
@andyscott andyscott mentioned this pull request Apr 6, 2022
Merged
@ncfavier
Copy link
Member

ncfavier commented May 10, 2022 •
edited
Loading

Any progress on fixing this? It would help with #172249 (comment)

(EDIT: this PR fixes #148189)

@sternenseemann
Copy link
Member Author

sternenseemann commented May 10, 2022

Someone with the appropriate hardware would need to pick this up, I can't look into the build problems personally.

@nixos-discourse
Copy link

nixos-discourse commented Dec 15, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/10

@Smaug123 Smaug123 mentioned this pull request Dec 28, 2022
Closed
13 tasks
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Mar 13, 2023
@sternenseemann
writers: make codesign_allocate available in PATH on aarch64-darwin
da69861 
codesign_allocate is assumed to be in PATH:

NixOS#154203
NixOS#148189

Using an absolute reference in post-link-sign-hook would be another
possibility, but hasn't been fruitful so far:
NixOS#148282
NixOS#208120
@sternenseemann sternenseemann mentioned this pull request Mar 13, 2023
Merged
12 tasks
sternenseemann added a commit that referenced this pull request Mar 14, 2023
@sternenseemann
writers: make codesign_allocate available in PATH on aarch64-darwin
86dbc92 
codesign_allocate is assumed to be in PATH:

#154203
#148189

Using an absolute reference in post-link-sign-hook would be another
possibility, but hasn't been fruitful so far:
#148282
#208120
@szlend szlend mentioned this pull request Jun 17, 2023
Merged
12 tasks
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2023
@tjni
Copy link
Contributor

tjni commented Aug 3, 2023

This should be superseded by #238323.

@tjni tjni closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sternenseemann @domenkozar @nixos-discourse @ncfavier @tjni