darwin.postLinkSignHook: fix reference to codesign_allocate#150074
Closed
Kha wants to merge 1 commit intoNixOS:stagingfrom
Closed
darwin.postLinkSignHook: fix reference to codesign_allocate#150074Kha wants to merge 1 commit intoNixOS:stagingfrom
Kha wants to merge 1 commit intoNixOS:stagingfrom
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/2 |
Member
|
cc @NixOS/darwin-maintainers |
Member
|
Got this while running |
Member
|
PR'd an evaluating, but otherwise untested version of this at #148282 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/repairing-codesign-allocate-on-darwin/16326/6 |
Contributor
Author
|
Closing in favor of #148282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation for this change
Make wrapped linkers work outside of stdenv, such as in
runCommand.Fixes #148189
Things done
As this triggers basically a full Darwin rebuild, I did not test more than building and running
bashsandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes/cc @thefloweringash