Skip to content

writers: make codesign_allocate available in PATH on aarch64-darwin#220966

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:writers-codesign
Mar 14, 2023
Merged

writers: make codesign_allocate available in PATH on aarch64-darwin#220966
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:writers-codesign

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Mar 13, 2023

codesign_allocate is assumed to be in PATH:

#154203
#148189

Using an absolute reference in post-link-sign-hook would be another possibility, but hasn't been fruitful so far:
#148282
#208120

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

codesign_allocate is assumed to be in PATH:

NixOS#154203
NixOS#148189

Using an absolute reference in post-link-sign-hook would be another
possibility, but hasn't been fruitful so far:
NixOS#148282
NixOS#208120
@sternenseemann
Copy link
Member Author

@ofborg build hledger-check-fancyassertions

@sternenseemann
Copy link
Member Author

@ofborg build tests.writers

@sternenseemann sternenseemann marked this pull request as ready for review March 13, 2023 09:26
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 13, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 13, 2023
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about darwin, this seems needed so I guess we could just merge it? although it feels like this should me solved somewhere else

@sternenseemann
Copy link
Member Author

although it feels like this should me solved somewhere else

Agreed, but I have pointed out this problem in 2021 in the context of pkgs.writers especially and nothing has happened since then. Furthermore, the “obvious” solution of using an absolute path in post-link-sign-hook causes illegal references during aarch64-darwin bootstrapping — that is something I have resolved not to debug, as I only have the stake in aarch64-darwin that I want to be left alone by it…

@domenkozar
Copy link
Member

Some weird errors, possibly unrelated:

/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 385: /nix/store/1k90017xnj85sh6l88ms6ss1zpcsin5q-pypy3.9-7.3.11-env/bin/python: No such file or directory
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 386: read: : invalid file descriptor specification
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 387: fd: ambiguous redirect
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 385: /nix/store/yfri14p11w6xg6bkj5mj51bnjsqsxbm1-pypy3.9-7.3.11/bin/python: No such file or directory
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 386: read: : invalid file descriptor specification
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 387: fd: ambiguous redirect
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 385: /nix/store/1k90017xnj85sh6l88ms6ss1zpcsin5q-pypy3.9-7.3.11-env/bin/python: No such file or directory
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 386: read: : invalid file descriptor specification
/nix/store/n98x0gdw15nadflnx50ikxrajsv8jf01-stdenv-darwin/setup: line 387: fd: ambiguous redirect
building '/nix/store/5ssx3xqrvz22dfzw6lnwdmcrj88l9g9f-run-test-writers-pypy3-no-libs.drv'...
building '/nix/store/wvdh4fyyc71ijfm9z8anblrvsggzfxd9-run-test-writers-pypy3-bin.drv'...
building '/nix/store/pbjx33mni62gldfgxh1aj7a73vasavh9-run-test-writers-pypy3.drv'...
error: 3 dependencies of derivation '/nix/store/jr1zd7dz2s510hm5knzj6yrvzymq5va5-test-writers.drv' failed to build

@sternenseemann
Copy link
Member Author

sternenseemann commented Mar 14, 2023

@ofborg tests.writers

Wonder if the ofborg builders are starting to have the same troubles as the Hydra ones.

@sternenseemann
Copy link
Member Author

@ofborg build tests.writers

@sternenseemann
Copy link
Member Author

The failures are all related to makeScriptWriter which isn't touched by this PR.

@sternenseemann sternenseemann merged commit 86dbc92 into NixOS:master Mar 14, 2023
@sternenseemann sternenseemann deleted the writers-codesign branch March 14, 2023 18:45
sternenseemann added a commit that referenced this pull request Mar 29, 2023
When authoring #220966, I missed that the `//` would take effect solely
in the else branch, fixing hledger-check-fancyassertions, but not
tests.writers.bin.haskell.
@szlend szlend mentioned this pull request Jun 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants