Skip to content

qemu: 6.0.0 -> 6.1.0#135877

Merged
alyssais merged 1 commit intoNixOS:masterfrom
erdnaxe:qemu
Sep 29, 2021
Merged

qemu: 6.0.0 -> 6.1.0#135877
alyssais merged 1 commit intoNixOS:masterfrom
erdnaxe:qemu

Conversation

@erdnaxe
Copy link
Member

@erdnaxe erdnaxe commented Aug 27, 2021

Tested building qemu_kvm, qemu_full, qemu_xen, and qemu_test on x86_64-linux.

I wasn't able to test building pkgsMusl.qemu_kvm as it fails to build libiscsi.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of some binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from alyssais and edolstra August 27, 2021 08:31
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 27, 2021
@alyssais alyssais self-assigned this Aug 27, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 27, 2021

Result of nixpkgs-review pr 135877 at 66adfbaa run on aarch64-linux 1

4 packages marked as broken and skipped:
  • qemu_xen
  • qemu_xen-light
  • qemu_xen_4_10
  • qemu_xen_4_10-light
19 packages skipped due to time constraints:
  • alpine-make-vm-image
  • aqemu
  • cloud-init
  • cloud-utils
  • cot (python39Packages.cot)
  • gnome.gnome-boxes
  • libguestfs
  • lima
  • multibootusb
  • out-of-tree
  • ...
3 packages built successfully:
  • nixos-install-tools
  • qemu_kvm
  • qemu_test

Result of nixpkgs-review pr 135877 at d344db95 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_latest.virtualbox
43 packages skipped due to time constraints:
  • alpine-make-vm-image
  • aqemu
  • cloud-init
  • cloud-utils
  • cot (python39Packages.cot)
  • diffoscope
  • gnome.gnome-boxes
  • libguestfs
  • lima
  • linuxPackages-libre.virtualbox
  • ...
5 packages built successfully:
  • nixos-install-tools
  • qemu_kvm
  • qemu_test
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
4 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/virtualization/qemu/utils.nix:11:3:

       |
    11 |   installPhase = ''
       |   ^
    
  • warning: build-tools-in-build-inputs

    makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/virtualization/qemu/default.nix:57:3:

       |
    57 |   buildInputs = [ zlib glib perl pixman
       |   ^
    
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/applications/virtualization/qemu/utils.nix:4:3:

      |
    4 |   name = "qemu-utils-${version}";
      |   ^
    

    Near pkgs/applications/virtualization/qemu/utils.nix:5:3:

      |
    5 |   version = qemu.version;
      |   ^
    
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern 'if exe_sign' doesn't match anything in file 'meson.build'
    Near pkgs/applications/virtualization/qemu/default.nix:209:0:

        |
    209 |     description = "A generic and open source machine emulator and virtualizer";
        | ^
    

@erdnaxe
Copy link
Member Author

erdnaxe commented Aug 27, 2021

Result of nixpkgs-review pr 135877 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • aqemu
  • linuxPackages-libre.virtualbox
  • linuxPackages_latest-libre.virtualbox
  • multibootusb
7 packages failed to build:
  • diffoscope
  • libguestfs
  • libguestfs-with-appliance
  • nixos-install-tools
  • python38Packages.guestfs
  • python39Packages.guestfs
  • vagrant
42 packages built:
  • alpine-make-vm-image
  • cloud-init
  • cloud-utils
  • cot (python39Packages.cot)
  • gnome.gnome-boxes
  • kvm (qemu_kvm)
  • lima
  • linuxPackages.virtualbox
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_14_hardened.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_19_hardened.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_hardened.virtualbox (linuxPackages_5_10_hardened.virtualbox)
  • linuxPackages_5_13.virtualbox
  • linuxPackages_5_4.virtualbox
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xanmod.virtualbox
  • linuxPackages_zen.virtualbox
  • ocamlPackages.mirage-bootvar-xen
  • ocamlPackages.mirage-net-xen
  • ocamlPackages.mirage-xen
  • ocamlPackages.netchannel
  • ocamlPackages.ocaml-freestanding
  • open-watcom-bin
  • out-of-tree
  • python38Packages.cot
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_test
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qtemu
  • solo5
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

@erdnaxe
Copy link
Member Author

erdnaxe commented Aug 27, 2021

libguestfs fails to build on:

make[3]: Entering directory '/build/libguestfs-1.40.2/test-data/blank-disks'
qemu-img create -f raw blank-disk-1s.raw 512
qemu-img create -f qcow2 -o preallocation=metadata blank-disk-1s.qcow2 512
qemu-img create -f raw blank-disk-1K.raw 1K
qemu-img create -f qcow2 -o preallocation=metadata blank-disk-1K.qcow2 1K
qemu-img create -f raw blank-disk-1M.raw 1M
qemu-img create -f qcow2 -o preallocation=metadata blank-disk-1M.qcow2 1M
Formatting 'blank-disk-1s.raw', fmt=raw size=512
Formatting 'blank-disk-1s.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off preallocation=metadata compression_type=zlib size=512 lazy_refcounts=off refcount_bits=16
Formatting 'blank-disk-1K.raw', fmt=raw size=1024
Formatting 'blank-disk-1K.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off preallocation=metadata compression_type=zlib size=1024 lazy_refcounts=off refcount_bits=16
Formatting 'blank-disk-1M.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off preallocation=metadata compression_type=zlib size=1048576 lazy_refcounts=off refcount_bits=16
Formatting 'blank-disk-1M.raw', fmt=raw size=1048576
qemu-img create -f qcow2 -b blank-disk-1M.raw blank-disk-with-backing.qcow2
qemu-img: blank-disk-with-backing.qcow2: Backing file specified without backing format
Detected format of raw.make[3]: *** [Makefile:1894: blank-disk-with-backing.qcow2] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/build/libguestfs-1.40.2/test-data/blank-disks'
make[2]: *** [Makefile:1774: all-recursive] Error 1
make[2]: Leaving directory '/build/libguestfs-1.40.2/test-data'
make[1]: *** [Makefile:1971: all-recursive] Error 1
make[1]: Leaving directory '/build/libguestfs-1.40.2'
make: *** [Makefile:1874: all] Error 2
builder for '/nix/store/522y18r29bisgj7h17ywiyh5y56awqg1-libguestfs-1.40.2.drv' failed with exit code 2

It seems like this is due to missing parameter -F raw at https://github.com/libguestfs/libguestfs/blob/v1.40.2/test-data/blank-disks/Makefile.am#L53. This has been fixed in libguestfs 1.42.0.

@erdnaxe erdnaxe mentioned this pull request Aug 27, 2021
12 tasks
@alyssais alyssais mentioned this pull request Aug 27, 2021
12 tasks
@risicle
Copy link
Contributor

risicle commented Aug 27, 2021

On macos 10.15:

builder for '/nix/store/11f0an2dm41r70lppcrzb1pm9ab5s1pr-qemu-6.1.0.drv' failed with exit code 1; last 10 log lines:
  clang -Ilibcommon.fa.p -I../capstone/include/capstone -I../dtc/libfdt -I../slirp -I../slirp/src -I. -Iqapi -Itrace -Iui -Iui/shader -I/nix/store/iyspkam85wgkbnhdfv7xwqyz2k9jrh3x-pixman-0.38.4/include/pixman-1 -I/nix/store/2d4hr4h6blqk2cz64j0sy5b3dyz941wd-zlib-1.2.11-dev/include -I/nix/store/6paaxpg9jyd96s4cg20n9ybfa18hf5h2-libpng-apng-1.6.37-dev/include/libpng16 -I/nix/store/8j9izkc6wm9ixq4vzfav2xxq7yc40f61-libjpeg-turbo-2.1.0-dev/include -I/nix/store/nsgamwa0azmj1w3x5w1h8c35rqdxiddy-gnutls-3.7.2-dev/include -I/nix/store/xzblkbdm8b9mnpf6zj1rzqhjyxx5c57c-glib-2.68.3-dev/include -I/nix/store/xzblkbdm8b9mnpf6zj1rzqhjyxx5c57c-glib-2.68.3-dev/include/glib-2.0 -I/nix/store/rhh9blnyck3w78q5mkz5cnvhcbj8m5mb-glib-2.68.3/lib/glib-2.0/include -I/nix/store/xzblkbdm8b9mnpf6zj1rzqhjyxx5c57c-glib-2.68.3-dev/include/gio-unix-2.0 -I/nix/store/ca1d9jkz8xhd39r5lkxpjp2qrvr4p0xd-libcacard-2.7.0/include/cacard -I/nix/store/8p6mwzvkjq7jxmrfj2d431i8ddkfka05-ncurses-6.2-dev/include -Xclang -fcolor-diagnostics -pipe -Wall -Winvalid-pch -O2 -g -iquote . -iquote /private/tmp/nix-build-qemu-6.1.0.drv-0/qemu-6.1.0 -iquote /private/tmp/nix-build-qemu-6.1.0.drv-0/qemu-6.1.0/include -iquote /private/tmp/nix-build-qemu-6.1.0.drv-0/qemu-6.1.0/disas/libvixl -iquote /private/tmp/nix-build-qemu-6.1.0.drv-0/qemu-6.1.0/tcg/i386 -m64 -mcx16 -DOS_OBJECT_USE_OBJC=0 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wno-initializer-overrides -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-string-plus-int -Wno-typedef-redefinition -Wno-tautological-type-limit-compare -Wno-missing-braces -D_DARWIN_C_SOURCE -DNCURSES_WIDECHAR -MD -MQ libcommon.fa.p/ui_cocoa.m.o -MF libcommon.fa.p/ui_cocoa.m.o.d -o libcommon.fa.p/ui_cocoa.m.o -c ../ui/cocoa.m
  clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
  ../ui/cocoa.m:1766:52: error: no type or protocol named 'NSPasteboardTypeOwner'
  @interface QemuCocoaPasteboardTypeOwner : NSObject<NSPasteboardTypeOwner>
                                                     ^
  ../ui/cocoa.m:1771:63: error: expected a type
  - (void)pasteboard:(NSPasteboard *)sender provideDataForType:(NSPasteboardType)type
                                                                ^
  2 errors generated.
  ninja: build stopped: subcommand failed.

@risicle
Copy link
Contributor

risicle commented Aug 27, 2021

Looks like the results of macos clipboard support being added: https://gitlab.com/qemu-project/qemu/-/commit/7e3e20d89129614f4a7b2451fe321cc6ccca3b76

From https://developer.apple.com/documentation/appkit/nspasteboardtypeowner:

Availability
macOS 10.14+

@risicle
Copy link
Contributor

risicle commented Aug 27, 2021

I've opened https://gitlab.com/qemu-project/qemu/-/issues/576 to get some more clarity on this.

@alyssais
Copy link
Member

Shall we disable clipboard support, by reverting that patch? No clipboard would be better than no QEMU at all.

@risicle
Copy link
Contributor

risicle commented Aug 28, 2021

You are reading my mind. Let's hope it un-applies cleanly...

@alyssais
Copy link
Member

@erdnaxe would fetchpatch with revert = true; have worked and saved us some repo/diff size?

@erdnaxe
Copy link
Member Author

erdnaxe commented Aug 28, 2021

@erdnaxe would fetchpatch with revert = true; have worked and saved us some repo/diff size?

Yes it works. I was not aware of this option, thanks!

@alyssais alyssais removed their assignment Aug 28, 2021
@erdnaxe
Copy link
Member Author

erdnaxe commented Aug 28, 2021

Result of nixpkgs-review pr 135877 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • aqemu
  • linuxPackages-libre.virtualbox
  • linuxPackages_latest-libre.virtualbox
  • multibootusb
1 package failed to build:
  • nixos-install-tools
48 packages built:
  • alpine-make-vm-image
  • cloud-init
  • cloud-utils
  • cot (python39Packages.cot)
  • diffoscope
  • gnome.gnome-boxes
  • kvm (qemu_kvm)
  • libguestfs
  • libguestfs-with-appliance
  • lima
  • linuxPackages.virtualbox
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_14_hardened.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_19_hardened.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_hardened.virtualbox (linuxPackages_5_10_hardened.virtualbox)
  • linuxPackages_5_13.virtualbox
  • linuxPackages_5_4.virtualbox
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xanmod.virtualbox
  • linuxPackages_zen.virtualbox
  • ocamlPackages.mirage-bootvar-xen
  • ocamlPackages.mirage-net-xen
  • ocamlPackages.mirage-xen
  • ocamlPackages.netchannel
  • ocamlPackages.ocaml-freestanding
  • open-watcom-bin
  • out-of-tree
  • python38Packages.cot
  • python38Packages.guestfs
  • python39Packages.guestfs
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_test
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qtemu
  • solo5
  • vagrant
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

@erdnaxe
Copy link
Member Author

erdnaxe commented Aug 28, 2021

1 package failed to build:

* nixos-install-tools

I don't really understand why it's failing with nixpkgs-review but it builds fine with nix-build -A nixos-install-tools. Maybe the fact that I am using swap during build is making something fail?

@alyssais
Copy link
Member

@ofborg build nixos-install-tools

@risicle
Copy link
Contributor

risicle commented Aug 29, 2021

https://gitlab.com/qemu-project/qemu/-/issues/576#note_663604432

AFAIK the latest version of QEMU requires macOS 10.15 or newer, so this should not be an issue.

Looks like life's about to get interesting for us.

Anyone actually tried the darwin patch-reverted build yet? Just spinning up my own darwin machine now...

@risicle
Copy link
Contributor

risicle commented Aug 29, 2021

On macos 10.15:

  /private/tmp/nix-build-qemu-host-cpu-only-6.1.0.drv-0/qemu-6.1.0/scripts/entitlement.sh qemu-system-x86_64 qemu-system-x86_64-unsigned ../pc-bios/qemu.rsrc ../accel/hvf/entitlements.plist
  /private/tmp/nix-build-qemu-host-cpu-only-6.1.0.drv-0/qemu-6.1.0/scripts/entitlement.sh: line 25: codesign: command not found

@domenkozar
Copy link
Member

domenkozar commented Aug 30, 2021

That needs darwin.signingUtils, although it will probably not work.

cc @toonn

@risicle
Copy link
Contributor

risicle commented Aug 30, 2021

No dice, signingUtils seems to be an empty package for me.

@toonn
Copy link
Contributor

toonn commented Aug 30, 2021

@thefloweringash knows more about the codesign situation. He implemented a custom utility for this IIRC. I think the build scripts are explicitly calling codesign, which isn't necessary pre-Big Sur AFAIK.

@risicle
Copy link
Contributor

risicle commented Aug 30, 2021

According to commit messages for entitlements.sh, it exists because:

However, the signature gets invalidated because meson modifies the code
to fix dynamic library install names during the install process.

The commit messages for that file tell more of the story: https://gitlab.com/qemu-project/qemu/-/commits/master/scripts/entitlement.sh

@sternenseemann
Copy link
Member

I can test if you give me some pointers.

@mstone
Copy link
Contributor

mstone commented Sep 4, 2021

Hi @erdnaxe, @risicle, @sternenseemann -- as mentioned above, I and a couple of other wonderful contributors are working on fixing up sigtool's codesign implementation to interoperate with qemu's entitlement.sh script, presently as proposed in thefloweringash/sigtool#7.

Assuming that this or a similar PR lands and that nixpkgs is then updated to use the new version of codesign that results, this packaging of qemu will then be easily fixable, probably best by adding sigtool as a conditional nativeBuildInput on darwin so that qemu's build-scripts will have access to the (fixed) version of codesign that it provides.

Once this is done, qemu will then be ad-hoc signed without entitlements and will build but will still only provide tcg accelerator on aarch64-darwin until

  1. patches similar to the A. Graf hvf accelerator patches tested in mstone/qemu-m1@076cae6 are merged and
  2. until nixpkgs+sigtool are further improved to deconflict qemu's codesigning-with-entitlements and the Darwin stdenv's automatic-codesigning-without-entitlements logic.

@alyssais
Copy link
Member

alyssais commented Sep 5, 2021

I'm assuming hvf wouldn't have worked with QEMU 6.0.0? If it didn't, there's no reason we need to block the update on having it work. Would it be enough to use @sternenseemann's change, and then rename the binaries to their normal names, to have a QEMU that was compatible with the status quo?

@alyssais
Copy link
Member

@mstone I see thefloweringash/sigtool#7 was merged. Can we make any progress here?

@erdnaxe
Copy link
Member Author

erdnaxe commented Sep 20, 2021

From what I understand, the following should be done:

  • wait for sigtool: 4a3719b4 -> 2a13539d #138453 to be merged then rebase this PR on it,
  • add sigtool as a conditional nativeBuildInput on darwin (and remove echo "#!${stdenv.shell}" > scripts/entitlement.sh).

Am I missing something?

@mstone
Copy link
Contributor

mstone commented Sep 23, 2021

@erdnaxe -- #138453 is merged now so, assuming it sticks, I think we are now ready to try out the rest of the plan that you outlined!

@erdnaxe erdnaxe force-pushed the qemu branch 2 times, most recently from 3f86e0f to b8fa7fe Compare September 25, 2021 06:06
@erdnaxe
Copy link
Member Author

erdnaxe commented Sep 25, 2021

Ofborg failed to build because it was not able to download QEMU sources, how can I retry the x86_64-darwin Ofborg build?

@mstone
Copy link
Contributor

mstone commented Sep 26, 2021

@erdnaxe from having just looked at ofborg’s comment parser, https://github.com/NixOS/ofborg/blob/released/ofborg/src/commentparser.rs, I don’t see a way to trigger a package build for a single system short of building the package everywhere since IIRC we don’t yet have access to a system-specific packageset like legacyPackages.<system>.<package> like the nixpkgs flake provides. Consequently, unless someone sees something better, let’s try:

@ofborg build qemu

@alyssais
Copy link
Member

We should be able to remove this now:

    # TODO: On aarch64-darwin, we automatically codesign everything, but qemu
    # needs specific entitlements and does its own signing. This codesign
    # command fails, but we have no fix at the moment, so this disables it.
    # This means `-accel hvf` is broken for now, on aarch64-darwin only.
    substituteInPlace meson.build \
      --replace 'if exe_sign' 'if false'

@alyssais alyssais merged commit 988da51 into NixOS:master Sep 29, 2021
@alyssais
Copy link
Member

@erdnaxe thanks for your patience! Darwin is such a pain.

@dasJ
Copy link
Member

dasJ commented Sep 29, 2021

This breaks unstable-small since it removes makeWrapper from nativeBuildInputs:

[…]
Installing /build/qemu-6.1.0/build/pc-bios/descriptors/60-edk2-aarch64.json to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/firmware
Installing /build/qemu-6.1.0/build/pc-bios/descriptors/60-edk2-arm.json to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/firmware
Installing /build/qemu-6.1.0/build/pc-bios/descriptors/60-edk2-i386.json to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/firmware
Installing /build/qemu-6.1.0/build/pc-bios/descriptors/60-edk2-x86_64.json to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/firmware
Installing /build/qemu-6.1.0/pc-bios/keymaps/sl to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/keymaps
Installing /build/qemu-6.1.0/pc-bios/keymaps/sv to /nix/store/78aljrpq41y20kdys3n7p4xyn22d5zaw-qemu-host-cpu-only-for-vm-tests-6.1.0/share/qemu/keymaps
/nix/store/r28nip42zvcr35lsndbgafqa9w4d91n0-stdenv-linux/setup: line 88: makeWrapper: command not found
builder for '/nix/store/apf5d02qslyixcz6x8kzms5sa4l0v0sn-qemu-host-cpu-only-for-vm-tests-6.1.0.drv' failed with exit code 127

@erdnaxe
Copy link
Member Author

erdnaxe commented Sep 29, 2021

This breaks unstable-small since it removes makeWrapper from nativeBuildInputs

My bad, I missed that while rebasing on current master. Should I open a new PR with this fix?

@dasJ
Copy link
Member

dasJ commented Sep 29, 2021

That's probably something one could push to master directly if they had the permissions (which I do not).

@dasJ dasJ mentioned this pull request Sep 29, 2021
12 tasks
@Artturin
Copy link
Member

added it back in a commit in #139890

@SuperSandro2000
Copy link
Member

Should I open a new PR with this fix?

Please always open a PR even if the change is very small.

@bobrik
Copy link
Contributor

bobrik commented Sep 29, 2021

I opened #139960 to take advantage of newly available sigtool on aarch64-darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.