Conversation
|
Result of 4 packages marked as broken and skipped:
19 packages skipped due to time constraints:
3 packages built successfully:
Result of 2 packages marked as broken and skipped:
43 packages skipped due to time constraints:
5 packages built successfully:
4 suggestions:
|
|
Result of 4 packages marked as broken and skipped:
7 packages failed to build:
42 packages built:
|
|
It seems like this is due to missing parameter |
|
On macos 10.15: |
|
Looks like the results of macos clipboard support being added: https://gitlab.com/qemu-project/qemu/-/commit/7e3e20d89129614f4a7b2451fe321cc6ccca3b76 From https://developer.apple.com/documentation/appkit/nspasteboardtypeowner:
|
|
I've opened https://gitlab.com/qemu-project/qemu/-/issues/576 to get some more clarity on this. |
|
Shall we disable clipboard support, by reverting that patch? No clipboard would be better than no QEMU at all. |
|
You are reading my mind. Let's hope it un-applies cleanly... |
|
@erdnaxe would |
Yes it works. I was not aware of this option, thanks! |
|
Result of 4 packages marked as broken and skipped:
1 package failed to build:
48 packages built:
|
I don't really understand why it's failing with nixpkgs-review but it builds fine with |
|
@ofborg build nixos-install-tools |
|
https://gitlab.com/qemu-project/qemu/-/issues/576#note_663604432
Looks like life's about to get interesting for us. Anyone actually tried the darwin patch-reverted build yet? Just spinning up my own darwin machine now... |
|
On macos 10.15: |
|
That needs darwin.signingUtils, although it will probably not work. cc @toonn |
|
No dice, |
|
@thefloweringash knows more about the codesign situation. He implemented a custom utility for this IIRC. I think the build scripts are explicitly calling codesign, which isn't necessary pre-Big Sur AFAIK. |
|
According to commit messages for
The commit messages for that file tell more of the story: https://gitlab.com/qemu-project/qemu/-/commits/master/scripts/entitlement.sh |
|
I can test if you give me some pointers. |
|
Hi @erdnaxe, @risicle, @sternenseemann -- as mentioned above, I and a couple of other wonderful contributors are working on fixing up sigtool's Assuming that this or a similar PR lands and that nixpkgs is then updated to use the new version of Once this is done, qemu will then be ad-hoc signed without entitlements and will build but will still only provide
|
|
I'm assuming hvf wouldn't have worked with QEMU 6.0.0? If it didn't, there's no reason we need to block the update on having it work. Would it be enough to use @sternenseemann's change, and then rename the binaries to their normal names, to have a QEMU that was compatible with the status quo? |
|
@mstone I see thefloweringash/sigtool#7 was merged. Can we make any progress here? |
|
From what I understand, the following should be done:
Am I missing something? |
3f86e0f to
b8fa7fe
Compare
|
Ofborg failed to build because it was not able to download QEMU sources, how can I retry the x86_64-darwin Ofborg build? |
|
@erdnaxe from having just looked at ofborg’s comment parser, https://github.com/NixOS/ofborg/blob/released/ofborg/src/commentparser.rs, I don’t see a way to trigger a package build for a single system short of building the package everywhere since IIRC we don’t yet have access to a system-specific packageset like @ofborg build qemu |
|
We should be able to remove this now: # TODO: On aarch64-darwin, we automatically codesign everything, but qemu
# needs specific entitlements and does its own signing. This codesign
# command fails, but we have no fix at the moment, so this disables it.
# This means `-accel hvf` is broken for now, on aarch64-darwin only.
substituteInPlace meson.build \
--replace 'if exe_sign' 'if false' |
|
@erdnaxe thanks for your patience! Darwin is such a pain. |
|
This breaks unstable-small since it removes |
My bad, I missed that while rebasing on current master. Should I open a new PR with this fix? |
|
That's probably something one could push to master directly if they had the permissions (which I do not). |
|
added it back in a commit in #139890 |
Please always open a PR even if the change is very small. |
|
I opened #139960 to take advantage of newly available |
Tested building
qemu_kvm,qemu_full,qemu_xen, andqemu_teston x86_64-linux.I wasn't able to test building
pkgsMusl.qemu_kvmas it fails to buildlibiscsi.Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)