Skip to content

qemu: enable hvf acceleration on aarch64-darwin#139960

Merged
veprbl merged 1 commit intoNixOS:masterfrom
bobrik:ivan/qemu-entitlements
Oct 1, 2021
Merged

qemu: enable hvf acceleration on aarch64-darwin#139960
veprbl merged 1 commit intoNixOS:masterfrom
bobrik:ivan/qemu-entitlements

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Sep 29, 2021

Motivation for this change

I can finally remove qemu_kvm from my overlay.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 29, 2021
@bobrik bobrik mentioned this pull request Sep 29, 2021
Merged
12 tasks
@bobrik bobrik force-pushed the ivan/qemu-entitlements branch from 3f18d95 to b1fd24b Compare September 29, 2021 20:39
@ofborg ofborg bot requested review from alyssais and edolstra September 29, 2021 20:45
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 29, 2021
@veprbl
Copy link
Member

veprbl commented Sep 29, 2021

Result of nixpkgs-review pr 139960 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • alpine-make-vm-image
9 packages built:
  • cot (python39Packages.cot)
  • kvm (qemu_kvm)
  • lima
  • out-of-tree
  • podman
  • python38Packages.cot
  • qemu
  • qemu-utils
  • qemu_test

@risicle
Copy link
Contributor

risicle commented Sep 29, 2021

nixpkgs-review succeeds on macos 10.15. Can't test any hypervisor functionality on this machine though.

@veprbl veprbl merged commit decdbc3 into NixOS:master Oct 1, 2021
@bobrik bobrik deleted the ivan/qemu-entitlements branch October 23, 2021 23:38
polynomial added a commit to extole/nixpkgs that referenced this pull request Nov 24, 2021
@polynomial
Revert "qemu: enable hvf acceleration on aarch64-darwin (NixOS#139960)"
f5d4c32 
This reverts commit decdbc3.
@rrbutani rrbutani mentioned this pull request Oct 9, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobrik @veprbl @risicle