Skip to content

pkgsMusl.libiscsi: fix build#135903

Merged
alyssais merged 1 commit intoNixOS:masterfrom
alyssais:libiscsi
Aug 30, 2021
Merged

pkgsMusl.libiscsi: fix build#135903
alyssais merged 1 commit intoNixOS:masterfrom
alyssais:libiscsi

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Aug 27, 2021

Motivation for this change

#135877 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from erdnaxe August 27, 2021 12:18
@ofborg ofborg bot requested a review from misuzu August 27, 2021 12:29
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 27, 2021
@erdnaxe
Copy link
Member

erdnaxe commented Aug 27, 2021

Result of nixpkgs-review pr 135903 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • aqemu
  • linuxPackages-libre.virtualbox
  • linuxPackages_latest-libre.virtualbox
  • multibootusb
49 packages built:
  • alpine-make-vm-image
  • cloud-init
  • cloud-utils
  • cot (python39Packages.cot)
  • diffoscope
  • gnome.gnome-boxes
  • kvm (qemu_kvm)
  • libguestfs
  • libguestfs-with-appliance
  • libiscsi
  • lima
  • linuxPackages.virtualbox
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_14_hardened.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_19_hardened.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_hardened.virtualbox (linuxPackages_5_10_hardened.virtualbox)
  • linuxPackages_5_13.virtualbox
  • linuxPackages_5_4.virtualbox
  • linuxPackages_5_4_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xanmod.virtualbox
  • linuxPackages_zen.virtualbox
  • ocamlPackages.mirage-bootvar-xen
  • ocamlPackages.mirage-net-xen
  • ocamlPackages.mirage-xen
  • ocamlPackages.netchannel
  • ocamlPackages.ocaml-freestanding
  • open-watcom-bin
  • out-of-tree
  • python38Packages.cot
  • python38Packages.guestfs
  • python39Packages.guestfs
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_test
  • qemu_xen (qemu_xen_4_10)
  • qemu_xen-light (qemu_xen_4_10-light)
  • qtemu
  • solo5
  • vagrant
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

@risicle
Copy link
Contributor

risicle commented Aug 27, 2021

nixpkgs-review happy, macos 10.15

r-burns
r-burns approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encountered in #135619

SuperSandro2000
SuperSandro2000 reviewed Aug 27, 2021
View reviewed changes
pkgs/development/libraries/libiscsi/default.nix
Comment on lines +21 to +22
NIX_CFLAGS_COMPILE =
lib.optional stdenv.hostPlatform.is32bit "-Wno-error=sign-compare";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NIX_CFLAGS_COMPILE =
lib.optional stdenv.hostPlatform.is32bit "-Wno-error=sign-compare";
NIX_CFLAGS_COMPILE = lib.optional stdenv.hostPlatform.is32bit "-Wno-error=sign-compare";

Copy link
Member Author

@alyssais alyssais Aug 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@alyssais alyssais added 6.topic: exotic Exotic hardware or software platform 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform labels Aug 28, 2021
@alyssais alyssais merged commit 78d20f2 into NixOS:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@r-burns r-burns r-burns approved these changes

@misuzu misuzu misuzu approved these changes

+1 more reviewer

@erdnaxe erdnaxe erdnaxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: exotic Exotic hardware or software platform 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alyssais @erdnaxe @risicle @misuzu @SuperSandro2000 @r-burns