Skip to content

jabref: 5.1 -> 5.3#134516

Closed
zoedsoupe wants to merge 2 commits intoNixOS:masterfrom
zoedsoupe:jabref
Closed

jabref: 5.1 -> 5.3#134516
zoedsoupe wants to merge 2 commits intoNixOS:masterfrom
zoedsoupe:jabref

Conversation

@zoedsoupe
Copy link
Member

Motivation for this change

Jabref continues to have incremental fixes and new features: https://github.com/JabRef/jabref/blob/main/CHANGELOG.md#53--2021-07-05 and build on NixOS is failing even with overlays.

See

For detailed info

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.


src = fetchurl {
url = "https://github.com/JabRef/jabref/releases/download/v${version}/JabRef-${version}-portable_linux.tar.gz";
src = fetchFromGiHub {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing the src from a builded version (...portable_linux.tar.gz) to source code and not adjusting the rest of the expression.

Either adapt the expression to build jabref from source or follow the existing pattern and just update version and sha256.

@linsui linsui mentioned this pull request Mar 3, 2022
13 tasks
@stale
Copy link

stale bot commented Apr 18, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants