Closed
Conversation
jnetod
reviewed
Aug 20, 2021
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/JabRef/jabref/releases/download/v${version}/JabRef-${version}-portable_linux.tar.gz"; | ||
| src = fetchFromGiHub { |
Contributor
There was a problem hiding this comment.
You're changing the src from a builded version (...portable_linux.tar.gz) to source code and not adjusting the rest of the expression.
Either adapt the expression to build jabref from source or follow the existing pattern and just update version and sha256.
|
I marked this as stale due to inactivity. → More info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Jabref continues to have incremental fixes and new features: https://github.com/JabRef/jabref/blob/main/CHANGELOG.md#53--2021-07-05 and build on NixOS is failing even with overlays.
See
For detailed info
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)