Skip to content

jabref: 5.1 -> 5.3 #134516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoedsoupe wants to merge 2 commits into from
Closed

jabref: 5.1 -> 5.3 #134516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1f48f
fix: my mainterner name and github user
Aug 17, 2021
f5e2135
fix: download source code
Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6650,6 +6650,16 @@
githubId = 775189;
name = "Jordi Masip";
};
matdsoupe = {
github = "matdsoupe";
githubId = 44469426;
name = "Matheus de Souza Pessanha";
email = "matheus_pessanha2001@outlook.com";
keys = [{
longkeyid = "rsa4096/6DFD656220A3B849";
fingerprint = "2D4D 488F 17FB FF75 664E C016 6DFD 6562 20A3 B849";
}];
};
matejc = {
email = "cotman.matej@gmail.com";
github = "matejc";
Expand Down Expand Up @@ -6856,16 +6866,6 @@
fingerprint = "D709 03C8 0BE9 ACDC 14F0 3BFB 77BF E531 397E DE94";
}];
};
mdsp = {
github = "Mdsp9070";
githubId = 44469426;
name = "Matheus de Souza Pessanha";
email = "matheus_pessanha2001@outlook.com";
keys = [{
longkeyid = "rsa4096/6DFD656220A3B849";
fingerprint = "2D4D 488F 17FB FF75 664E C016 6DFD 6562 20A3 B849";
}];
};
meatcar = {
email = "nixpkgs@denys.me";
github = "meatcar";
Expand Down
10 changes: 6 additions & 4 deletions pkgs/applications/office/jabref/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
, zlib , libX11, libXext, libXi, libXrender, libXtst, libGL, alsa-lib, cairo, freetype, pango, gdk-pixbuf, glib }:

stdenv.mkDerivation rec {
version = "5.1";
version = "5.3";
pname = "jabref";

src = fetchurl {
url = "https://github.com/JabRef/jabref/releases/download/v${version}/JabRef-${version}-portable_linux.tar.gz";
src = fetchFromGiHub {
Copy link
Contributor

@jnetod jnetod Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing the src from a builded version (...portable_linux.tar.gz) to source code and not adjusting the rest of the expression.

Either adapt the expression to build jabref from source or follow the existing pattern and just update version and sha256.

owner = "JabRef";
repo = pname;
rev = "v${version}";
sha256 = "04f612byrq3agzy26byg1sgrjyhcpa8xfj0ssh8dl8d8vnhx9742";
};

Expand Down Expand Up @@ -67,6 +69,6 @@ stdenv.mkDerivation rec {
homepage = "https://www.jabref.org";
license = licenses.gpl2;
platforms = platforms.unix;
maintainers = [ maintainers.gebner ];
maintainers = with maintainers; [ gebner matdsoupe ];
};
}