Skip to content

abseil-cpp: 20200923.3 -> 20210324.1#124030

Merged
gebner merged 3 commits intoNixOS:masterfrom
gebner:abseil202103241
May 22, 2021
Merged

abseil-cpp: 20200923.3 -> 20210324.1#124030
gebner merged 3 commits intoNixOS:masterfrom
gebner:abseil202103241

Conversation

@gebner
Copy link
Member

@gebner gebner commented May 22, 2021

Motivation for this change

The bear build was broken due to grpc upgrade in #123855. Upgrading abseil seemed liked the easiest fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@gebner gebner mentioned this pull request May 22, 2021
Merged
9 tasks
@ofborg ofborg bot requested review from RaghavSood, andersk and offlinehacker May 22, 2021 14:18
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 22, 2021
SuperSandro2000
SuperSandro2000 reviewed May 22, 2021
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed May 22, 2021
View reviewed changes
@gebner gebner force-pushed the abseil202103241 branch from c4b5c5c to 5fe63fc Compare May 22, 2021 14:57
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 22, 2021 •
edited
Loading

Result of nixpkgs-review pr 124030 at c4b5c5c7 run on aarch64-linux 1

44 packages marked as broken and skipped:
  • python38Packages.arviz
  • python38Packages.dm-sonnet
  • python38Packages.graph_nets
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.rl-coach
  • python38Packages.spacy
  • python38Packages.spacy-transformers
  • python38Packages.tensorflow-probability
  • python38Packages.tensorflowWithCuda
  • ...
28 packages skipped due to time constraints:
  • bear
  • deja-dup
  • duplicity
  • duply
  • fcitx5-mozc
  • home-assistant
  • kmymoney
  • murmur
  • or-tools
  • python38Packages.baselines
  • ...
89 packages built successfully:
  • abseil-cpp
  • beancount (python38Packages.beancount)
  • dvc-with-remotes
  • fava
  • gcalcli
  • git-annex-remote-googledrive
  • grpc
  • ledger2beancount
  • lieer
  • lndmanage
  • python38Packages.beancount_docverif
  • python38Packages.chirpstack-api
  • python38Packages.drivelib
  • python38Packages.goobook
  • python38Packages.google-api-core
  • python38Packages.google-api-python-client
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-asset
  • python38Packages.google-cloud-automl
  • python38Packages.google-cloud-bigquery
  • python38Packages.google-cloud-bigquery-datatransfer
  • python38Packages.google-cloud-bigtable
  • python38Packages.google-cloud-container
  • python38Packages.google-cloud-core
  • python38Packages.google-cloud-dataproc
  • python38Packages.google-cloud-datastore
  • python38Packages.google-cloud-dlp
  • python38Packages.google-cloud-dns
  • python38Packages.google-cloud-error-reporting
  • python38Packages.google-cloud-firestore
  • python38Packages.google-cloud-iam
  • python38Packages.google-cloud-iot
  • python38Packages.google-cloud-kms
  • python38Packages.google-cloud-language
  • python38Packages.google-cloud-logging
  • python38Packages.google-cloud-monitoring
  • python38Packages.google-cloud-org-policy
  • python38Packages.google-cloud-os-config
  • python38Packages.google-cloud-pubsub
  • python38Packages.google-cloud-redis
  • python38Packages.google-cloud-resource-manager
  • python38Packages.google-cloud-runtimeconfig
  • python38Packages.google-cloud-secret-manager
  • python38Packages.google-cloud-securitycenter
  • python38Packages.google-cloud-spanner
  • python38Packages.google-cloud-speech
  • python38Packages.google-cloud-storage
  • python38Packages.google-cloud-tasks
  • python38Packages.google-cloud-texttospeech
  • python38Packages.google-cloud-trace
  • python38Packages.google-cloud-translate
  • python38Packages.google-cloud-videointelligence
  • python38Packages.google-cloud-vision
  • python38Packages.google-cloud-websecurityscanner
  • python38Packages.googleapis-common-protos
  • python38Packages.grpc_google_iam_v1
  • python38Packages.ortools
  • python38Packages.pathy
  • python38Packages.proto-plus
  • python38Packages.pydrive
  • python38Packages.weboob
  • python38Packages.woob
  • python39Packages.beancount
  • python39Packages.beancount_docverif
  • python39Packages.chirpstack-api
  • python39Packages.drivelib
  • python39Packages.goobook
  • python39Packages.google-api-core
  • python39Packages.google-api-python-client
  • python39Packages.google-cloud-access-context-manager
  • python39Packages.google-cloud-bigtable
  • python39Packages.google-cloud-core
  • python39Packages.google-cloud-dns
  • python39Packages.google-cloud-firestore
  • python39Packages.google-cloud-logging
  • python39Packages.google-cloud-org-policy
  • python39Packages.google-cloud-resource-manager
  • python39Packages.google-cloud-runtimeconfig
  • python39Packages.google-cloud-trace
  • python39Packages.google-cloud-videointelligence
  • python39Packages.googleapis-common-protos
  • python39Packages.grpc_google_iam_v1
  • python39Packages.oauthenticator
  • python39Packages.ortools
  • python39Packages.proto-plus
  • python39Packages.pydrive
  • python39Packages.weboob
  • python39Packages.woob
  • wal_e
1 suggestion:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/libraries/science/math/or-tools/default.nix:4:3:

      |
4 | , fetchpatch
  |   ^

Result of nixpkgs-review pr 124030 at 5fe63fc run on x86_64-linux 1

46 packages marked as broken and skipped:
  • linuxPackages-libre.sysdig
  • linuxPackages_4_4.sysdig
  • linuxPackages_4_9.sysdig
  • linuxPackages_hardkernel_4_14.sysdig
  • linuxPackages_hardkernel_latest.sysdig
  • linuxPackages_latest-libre.sysdig
  • python38Packages.arviz
  • python38Packages.dm-sonnet
  • python38Packages.graph_nets
  • python38Packages.optuna
  • ...
62 packages skipped due to time constraints:
  • bear
  • deja-dup
  • duplicity
  • duply
  • dvc-with-remotes
  • fava
  • fcitx5-mozc
  • google-cloud-cpp
  • gpt2tc
  • home-assistant
  • ...
76 packages built successfully:
  • abseil-cpp
  • beancount (python38Packages.beancount)
  • gcalcli
  • git-annex-remote-googledrive
  • grpc
  • ledger2beancount
  • lieer
  • python38Packages.beancount_docverif
  • python38Packages.chirpstack-api
  • python38Packages.drivelib
  • python38Packages.goobook
  • python38Packages.google-api-core
  • python38Packages.google-api-python-client
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-asset
  • python38Packages.google-cloud-bigquery-datatransfer
  • python38Packages.google-cloud-bigtable
  • python38Packages.google-cloud-container
  • python38Packages.google-cloud-core
  • python38Packages.google-cloud-dataproc
  • python38Packages.google-cloud-datastore
  • python38Packages.google-cloud-dns
  • python38Packages.google-cloud-error-reporting
  • python38Packages.google-cloud-iam
  • python38Packages.google-cloud-iot
  • python38Packages.google-cloud-kms
  • python38Packages.google-cloud-language
  • python38Packages.google-cloud-logging
  • python38Packages.google-cloud-monitoring
  • python38Packages.google-cloud-org-policy
  • python38Packages.google-cloud-os-config
  • python38Packages.google-cloud-pubsub
  • python38Packages.google-cloud-redis
  • python38Packages.google-cloud-resource-manager
  • python38Packages.google-cloud-runtimeconfig
  • python38Packages.google-cloud-secret-manager
  • python38Packages.google-cloud-securitycenter
  • python38Packages.google-cloud-speech
  • python38Packages.google-cloud-storage
  • python38Packages.google-cloud-tasks
  • python38Packages.google-cloud-texttospeech
  • python38Packages.google-cloud-trace
  • python38Packages.google-cloud-translate
  • python38Packages.google-cloud-videointelligence
  • python38Packages.google-cloud-websecurityscanner
  • python38Packages.googleapis-common-protos
  • python38Packages.grpc_google_iam_v1
  • python38Packages.oauthenticator
  • python38Packages.ortools
  • python38Packages.proto-plus
  • python38Packages.pydrive
  • python38Packages.weboob
  • python38Packages.woob
  • python39Packages.beancount
  • python39Packages.beancount_docverif
  • python39Packages.chirpstack-api
  • python39Packages.drivelib
  • python39Packages.goobook
  • python39Packages.google-api-core
  • python39Packages.google-api-python-client
  • python39Packages.google-cloud-access-context-manager
  • python39Packages.google-cloud-core
  • python39Packages.google-cloud-dns
  • python39Packages.google-cloud-logging
  • python39Packages.google-cloud-org-policy
  • python39Packages.google-cloud-resource-manager
  • python39Packages.google-cloud-runtimeconfig
  • python39Packages.google-cloud-trace
  • python39Packages.google-cloud-videointelligence
  • python39Packages.googleapis-common-protos
  • python39Packages.grpc_google_iam_v1
  • python39Packages.ortools
  • python39Packages.proto-plus
  • python39Packages.pydrive
  • python39Packages.woob
  • wal_e
2 suggestions:
  • warning: missing-phase-hooks

    checkPhase should probably contain runHook preCheck and runHook postCheck.

    Near pkgs/servers/rippled/default.nix:156:3:

        |
156 |   checkPhase = ''
    |   ^
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/development/libraries/science/math/or-tools/default.nix:36:3:

       |
36 |   configurePhase = ''
   |   ^

@gebner
Copy link
Member Author

gebner commented May 22, 2021

I can't reproduce the build error on ofborg (apparently some dependency of rippled fails to build), rippled builds fine here.

@gebner
Copy link
Member Author

gebner commented May 22, 2021

Merging this PR since it also fixes other packages like murmur. #123855 (comment)

@gebner gebner merged commit fc9a86a into NixOS:master May 22, 2021
@mweinelt mweinelt mentioned this pull request May 22, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@andersk andersk Awaiting requested review from andersk

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gebner @r-rmcgibbo @SuperSandro2000