nixos/botamusique: init

[mweinelt]

Motivation for this change

Proper setup of botamusique, a mumble music bot.

I did look into certificate creation, the upstreams example looks like this:

openssl req -x509 -nodes -days 3650 -newkey rsa:2048 -keyout botamusique.pem -out botamusique.pem -subj "/CN=botamusique"

Something users could do themselves, or we could handle it in ExecStartPre, not sure.

I did not look into what giving the bot tokens would do, I guess allow them to register?

Both could be exposed at the top-level, certificate is actually a path, tokens are literal strings. Nothing really security-critical ig.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[mweinelt]

Added a nixos test and configured it as a passthru test. I think feature-wise this is as far as I would go in this iteration. No certificate handling.

[mweinelt]

And pushed an update for botamusique that allows setting the bandwidth to something more reasonable than 200 kbit/s.

[mweinelt]

Updated to the latest version, that disables fetching the changelog, when autoupdates are disabled. This allows me to drop the patch I applied to the package in the nixos test.

Test currently doesn't complete, due to murmur being unable to find grpc.
Fixed in #124030.

[jonringer]

otherwise LGTM

[jonringer]

Do you mind expanding this description, usually nice to give a concise description of the package and what enabling the service does

Suggested change

	enable = mkEnableOption "botamusique";
	enable = mkEnableOption "Enable botamusique service to play youtube or sound on mumble.";

[andir]

That is redundant: https://github.com/NixOS/nixpkgs/blob/master/lib/options.nix#L92-L99

Usually you just pass the service name to mkEnableOption

[mweinelt]

Updated, thanks!

[jonringer]

Oh didn't realize that it constructed the description. sorry!