Skip to content

grpc: 1.37.1 -> 1.38.0#123855

Merged
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc
May 22, 2021
Merged

grpc: 1.37.1 -> 1.38.0#123855
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented May 21, 2021

Motivation for this change

https://github.com/grpc/grpc/releases/tag/v1.38.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@marsam marsam requested review from FRidh and jonringer as code owners May 21, 2021 01:25
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 21, 2021
@ofborg ofborg bot requested a review from LnL7 May 21, 2021 01:35
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 21, 2021
@marsam marsam changed the title Update grpc grpc: 1.37.1 -> 1.38.0 May 21, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123855 at 99a856c run on aarch64-linux 1

55 packages marked as broken and skipped:
  • python38Packages.arviz
  • python38Packages.dm-sonnet
  • python38Packages.graph_nets
  • python38Packages.ignite
  • python38Packages.optuna
  • python38Packages.pymc3
  • python38Packages.pytorchWithCuda
  • python38Packages.pywick
  • python38Packages.rl-coach
  • python38Packages.shap
  • ...
7 packages failed to build:
37 packages skipped due to time constraints:
  • kmymoney
  • python38Packages.baselines
  • python38Packages.edward
  • python38Packages.mask-rcnn
  • python38Packages.pyro-ppl
  • python38Packages.pytorch (python38Packages.pytorchWithoutCuda)
  • python38Packages.pytorch-lightning
  • python38Packages.pytorch-metric-learning
  • python38Packages.rising
  • python38Packages.scikit-tda
  • ...
98 packages built successfully:
  • beancount (python38Packages.beancount)
  • cinnamon.warpinator
  • deja-dup
  • duplicity
  • duply
  • dvc-with-remotes
  • fava
  • gcalcli
  • git-annex-remote-googledrive
  • grpc
  • ledger2beancount
  • lieer
  • lndmanage
  • opensnitch-ui
  • python38Packages.beancount_docverif
  • python38Packages.chirpstack-api
  • python38Packages.drivelib
  • python38Packages.goobook
  • python38Packages.google-api-core
  • python38Packages.google-api-python-client
  • python38Packages.google-cloud-access-context-manager
  • python38Packages.google-cloud-asset
  • python38Packages.google-cloud-automl
  • python38Packages.google-cloud-bigquery
  • python38Packages.google-cloud-bigquery-datatransfer
  • python38Packages.google-cloud-bigtable
  • python38Packages.google-cloud-container
  • python38Packages.google-cloud-core
  • python38Packages.google-cloud-dataproc
  • python38Packages.google-cloud-datastore
  • python38Packages.google-cloud-dlp
  • python38Packages.google-cloud-dns
  • python38Packages.google-cloud-error-reporting
  • python38Packages.google-cloud-firestore
  • python38Packages.google-cloud-iam
  • python38Packages.google-cloud-iot
  • python38Packages.google-cloud-kms
  • python38Packages.google-cloud-language
  • python38Packages.google-cloud-logging
  • python38Packages.google-cloud-monitoring
  • python38Packages.google-cloud-org-policy
  • python38Packages.google-cloud-os-config
  • python38Packages.google-cloud-pubsub
  • python38Packages.google-cloud-redis
  • python38Packages.google-cloud-resource-manager
  • python38Packages.google-cloud-runtimeconfig
  • python38Packages.google-cloud-secret-manager
  • python38Packages.google-cloud-securitycenter
  • python38Packages.google-cloud-spanner
  • python38Packages.google-cloud-speech
  • python38Packages.google-cloud-storage
  • python38Packages.google-cloud-tasks
  • python38Packages.google-cloud-texttospeech
  • python38Packages.google-cloud-trace
  • python38Packages.google-cloud-translate
  • python38Packages.google-cloud-videointelligence
  • python38Packages.google-cloud-vision
  • python38Packages.google-cloud-websecurityscanner
  • python38Packages.googleapis-common-protos
  • python38Packages.grpc_google_iam_v1
  • python38Packages.grpcio
  • python38Packages.grpcio-gcp
  • python38Packages.grpcio-tools
  • python38Packages.oauthenticator
  • python38Packages.pathy
  • python38Packages.proto-plus
  • python38Packages.pydrive
  • python38Packages.weboob
  • python38Packages.woob
  • python39Packages.beancount
  • python39Packages.beancount_docverif
  • python39Packages.chirpstack-api
  • python39Packages.drivelib
  • python39Packages.goobook
  • python39Packages.google-api-core
  • python39Packages.google-api-python-client
  • python39Packages.google-cloud-access-context-manager
  • python39Packages.google-cloud-bigtable
  • python39Packages.google-cloud-core
  • python39Packages.google-cloud-dns
  • python39Packages.google-cloud-firestore
  • python39Packages.google-cloud-logging
  • python39Packages.google-cloud-org-policy
  • python39Packages.google-cloud-resource-manager
  • python39Packages.google-cloud-runtimeconfig
  • python39Packages.google-cloud-trace
  • python39Packages.google-cloud-videointelligence
  • python39Packages.googleapis-common-protos
  • python39Packages.grpc_google_iam_v1
  • python39Packages.grpcio
  • python39Packages.grpcio-gcp
  • python39Packages.grpcio-tools
  • python39Packages.oauthenticator
  • python39Packages.proto-plus
  • python39Packages.pydrive
  • python39Packages.weboob
  • python39Packages.woob
  • wal_e
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/grpcio-tools/default.nix:27:5:

       |
    27 |     maintainers = with maintainers; [ ];
       |     ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@marsam marsam merged commit 6bf9e13 into NixOS:master May 22, 2021
@marsam marsam deleted the update-grpc branch May 22, 2021 01:53
@gebner
Copy link
Member

gebner commented May 22, 2021

Are you sure that grpc 1.38 is supposed to work with the current abseil version? The grpc pkg-config files require absl_base and more, but our abseil version doesn't even provide pkg-config files.

This breaks at least bear. Upgrading abseil fixes this. #124030

@mweinelt
Copy link
Member

I bisected the murmur breakage to this merge request:

04e18727c4f1797b00e9505ac9185a38c764e0f1 is the first bad commit
commit 04e18727c4f1797b00e9505ac9185a38c764e0f1
Author: Mario Rodas <marsam@users.noreply.github.com>
Date:   Thu May 20 04:20:00 2021 +0000

    grpc: 1.37.1 -> 1.38.0
    
    https://github.com/grpc/grpc/releases/tag/v1.38.0

 pkgs/development/libraries/grpc/default.nix | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

It looks like this, even though grpc inputs are conditional and default to false:

cd src/murmur/ && ( test -e Makefile || /nix/store/b7jqnhqn6mw9ly6dk1232hddbnc1166z-qtbase-5.15.2-dev/bin/qmake -o Makefile /build/source/src/murmur/murmur.pro PREFIX=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4 NIX_OUTPUT_OUT=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4 NIX_OUTPUT_DEV=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4 NIX_OUTPUT_BIN=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4 NIX_OUTPUT_DOC=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4/share/doc/qt-5.15.2 NIX_OUTPUT_QML=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4/lib/qt-5.15.2/qml NIX_OUTPUT_PLUGIN=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4/lib/qt-5.15.2/plugins CONFIG+=release CONFIG+=c++11 CONFIG+=shared CONFIG+=no-g15 CONFIG+=packaged CONFIG+=no-update CONFIG+=no-embed-qt-translations CONFIG+=bundled-celt CONFIG+=no-bundled-opus CONFIG+=no-bundled-speex DEFINES+=PLUGIN_PATH=/nix/store/zxrq27ja0pnbr47fcmlm9ywlh41v86pg-murmur-1.3.4/lib/mumble CONFIG+=no-speechd CONFIG+=no-client CONFIG+=grpc ) && make -f Makefile release
Project ERROR: pkg-config could not find package grpc
make: *** [Makefile:500: sub-src-murmur-release_ordered] Error 3
builder for '/nix/store/xr1rvv464zyh7hxv5piwrh2nzj8p024y-murmur-1.3.4.drv' failed with exit code 2

@gebner
Copy link
Member

gebner commented May 22, 2021

@mweinelt murmur builds with #124030, I think I'm just gonna merge that PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants