mediatomb: use ffmpeg instead of ffmpeg_3

[dotlambda]

Motivation for this change

#120705

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

The test nixos/tests/mediatomb.nix fails, but it also does on master.

[r-rmcgibbo]

Result of nixpkgs-review pr 123487 at 740c393 run on x86_64-linux 1

2 packages built successfully:

• mediatomb
• tests.trivial

3 suggestions:

• warning: build-tools-in-build-inputs

  autoreconfHook is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/servers/mediatomb/default.nix:15:3:

     |
  15 |   buildInputs = [ sqlite expat spidermonkey_68 taglib libexif curl ffmpeg file mp4v2 flac
     |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/servers/mediatomb/default.nix:22:5:

     |
  22 |     license = licenses.gpl2;
     |     ^
  

• warning: build-tools-in-build-inputs

  pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/servers/mediatomb/default.nix:15:3:

     |
  15 |   buildInputs = [ sqlite expat spidermonkey_68 taglib libexif curl ffmpeg file mp4v2 flac
     |   ^
  

---

Result of nixpkgs-review pr 123487 at 740c393 run on aarch64-linux 1

1 package built successfully:

• mediatomb

[schmittlauch]

@dotlambda While mediatomb still compiles after changing from ffmpeg_3 to ffmpeg, tests now fail:

$ nix build -f nixos/tests/mediatomb.nix                                                                                                                                               1 ↵
waiting for locks or build slots...
builder for '/nix/store/fvz5r24n5jal267g11hjf772dbv3w2fk-vm-test-run-mediatomb.drv' failed with exit code 1; last 10 log lines:
      exec(tests, globals())
    File "<string>", line 1, in <module>
    File "<string>", line 23, in <module>
    File "/nix/store/mi8ay9gb6kv346mk3sz4gwj6r2nkvbkl-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 466, in succeed
      raise Exception(
  Exception: command `curl --fail http://serverGerbera:49152/` failed (exit code 52)
  cleaning up
  killing client (pid 10)
  killing serverGerbera (pid 22)
  (0.00 seconds)
[283 built (1 failed), 276 copied (1190.4 MiB), 209.6 MiB DL]
error: build of '/nix/store/fvz5r24n5jal267g11hjf772dbv3w2fk-vm-test-run-mediatomb.drv' failed

As mediatomb hasn't been updated since 2014, I consider dropping it and aliasing both the package as well as the module to gerbera, continuation fork.

[dotlambda]

@schmittlauch I would rather remove it completely since the module already uses gerbera by default. We could keep it marked as insecure in 21.05 but remove it from master.

[schmittlauch]

LGTM

@dotlambda Okay, change of plans: I'd LGTM this PR, because it does not cause the test failure. The tests are already failing with ffmpeg_3, and it's not mediatomb that is failing but gerbera which is tested in the same run.

Unfortunately gerbera is set as the new default, see #100348. So with hopefully getting mediatomb to build and run with this PR, we might ensure that this is still usable in 21.05 in case gerbera is really broken and not just its test.

[schmittlauch]

Dropping mediatomb in favor of gerbera is endavour we shall take for 21.11 then.